Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[L0] Check that program is in exe state in urProgramGetGlobalVariablePointer #2370

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

againull
Copy link
Contributor

@againull againull commented Nov 22, 2024

I.e. make behavior similar to urProgramGetFunctionPointer.

intel/llvm PR: intel/llvm#16156

@againull againull requested review from a team as code owners November 22, 2024 00:01
@againull againull changed the title [L0] Chech that program is in exe state in urProgramGetGlobalVariablePointer [L0] Check that program is in exe state in urProgramGetGlobalVariablePointer Nov 22, 2024
Copy link
Contributor

@nrspruit nrspruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@againull
Copy link
Contributor Author

@oneapi-src/unified-runtime-maintain Can I ask you to merge this please, this issue is causing massive device sanitizer test failures in multi-device environment downstream.

@kbenzie kbenzie added the ready to merge Added to PR's which are ready to merge label Nov 22, 2024
@callumfare callumfare merged commit 2f479e0 into oneapi-src:main Nov 22, 2024
72 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Added to PR's which are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants