Index into property array in urDevicePartition for OpenCL #2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callumfare
approved these changes
Nov 14, 2024
|
Is it possible to have some kind of CTS or regression test for this? |
|
@alycm I think that would be possible, I can make an issue to come back later and create one, or would you prefer it is done in this PR? |
Add new CTS test to check valid counts and ordering.
640bd26 to
1f68788
Compare
kbenzie
approved these changes
Nov 22, 2024
|
@alycm added a CTS test for this |
martygrant
added a commit
to intel/llvm
that referenced
this pull request
Nov 22, 2024
oneapi-src/unified-runtime#2326 --------- Co-authored-by: Callum Fare <callum@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
urDevicePartitionin the OpenCL adapter we loop through the array of properties but were not actually indexing into the array, only using the first element of the array.Also added a new CTS test to verify this behaviour.
intel/llvm#16083