[NFC] Warning squishing #2066
Merged
[NFC] Warning squishing #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cppchedy
approved these changes
Sep 10, 2024
aarongreig
approved these changes
Sep 10, 2024
kbenzie
reviewed
Sep 10, 2024
This fixes some warnings picked up by GCC 11 and Clang 20 when -Wextra is set. Note that -Wextra is not currently set on any command line - I'll do that seperately as part of a more general "hardening" commit.
e71d2a8 to
420d79e
Compare
|
@oneapi-src/unified-runtime-level-zero-write and @oneapi-src/unified-runtime-command-buffer-write can you have a quick look at that and see if it makes sense? |
pbalcer
approved these changes
Sep 12, 2024
Bensuo
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some warnings picked up by GCC 11 and Clang 20 when -Wextra is set. Note that -Wextra is not currently set on any command line - I'll do that separately as part of a more general "hardening" commit.