Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CUDA][HIP] Fix urUSMGetMemAllocInfo impl to use single platform. #1669

Merged
merged 2 commits into from
Jun 5, 2024
Merged

[CUDA][HIP] Fix urUSMGetMemAllocInfo impl to use single platform. #1669

merged 2 commits into from
Jun 5, 2024

Conversation

JackAKirk
Copy link
Contributor

Now all devices are in a single platform for both cuda and hip, this needs updating.

Fixes intel/llvm#6749 (comment)

@JackAKirk
Fix urUSMGetMemAllocInfo
0647802 
Now all devs are in a single platform this needs updating.

Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@JackAKirk JackAKirk requested review from a team as code owners May 27, 2024 13:01
@JackAKirk JackAKirk requested review from steffenlarsen and hdelan May 27, 2024 13:01
@github-actions github-actions bot added cuda CUDA adapter specific issues hip HIP adapter specific issues labels May 27, 2024
hdelan
hdelan approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@hdelan hdelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works then LGTM

@JackAKirk
Fix format.
9868e3b 
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@JackAKirk JackAKirk mentioned this pull request May 28, 2024
Closed
@JackAKirk
Copy link
Contributor Author

dpc++ test CI here: intel/llvm#13933

steffenlarsen
steffenlarsen approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@npmiller npmiller added the ready to merge Added to PR's which are ready to merge label May 30, 2024
@kbenzie kbenzie merged commit f06bc02 into oneapi-src:main Jun 5, 2024
51 checks passed
kbenzie added a commit to kbenzie/intel-llvm that referenced this pull request Jun 5, 2024
@kbenzie
[UR] Bump main tag to f06bc02
ac25d75 
Includes the following:

* oneapi-src/unified-runtime#1653
* oneapi-src/unified-runtime#1568
* oneapi-src/unified-runtime#1634
* oneapi-src/unified-runtime#1669
@kbenzie kbenzie mentioned this pull request Jun 5, 2024
Merged
kbenzie added a commit to kbenzie/intel-llvm that referenced this pull request Jun 5, 2024
@kbenzie
[UR] Bump main tag to f06bc02
27525cd 
Includes the following:

* oneapi-src/unified-runtime#1653
* oneapi-src/unified-runtime#1568
* oneapi-src/unified-runtime#1634
* oneapi-src/unified-runtime#1669
kbenzie added a commit to kbenzie/intel-llvm that referenced this pull request Jun 6, 2024
@kbenzie
[UR] Bump main tag to f06bc02
18606da 
Includes the following:

* oneapi-src/unified-runtime#1653
* oneapi-src/unified-runtime#1568
* oneapi-src/unified-runtime#1634
* oneapi-src/unified-runtime#1669
kbenzie added a commit to kbenzie/intel-llvm that referenced this pull request Jun 6, 2024
@kbenzie
[UR] Bump main tag to f06bc02
5e11e98 
Includes the following:

* oneapi-src/unified-runtime#1653
* oneapi-src/unified-runtime#1568
* oneapi-src/unified-runtime#1634
* oneapi-src/unified-runtime#1669
kbenzie added a commit to kbenzie/intel-llvm that referenced this pull request Jun 7, 2024
@kbenzie
[UR] Bump main tag to f06bc02
b105a38 
Includes the following:

* oneapi-src/unified-runtime#1653
* oneapi-src/unified-runtime#1568
* oneapi-src/unified-runtime#1634
* oneapi-src/unified-runtime#1669
martygrant pushed a commit to intel/llvm that referenced this pull request Jun 10, 2024
@kbenzie
[UR] Bump main tag to f06bc02 (#14047)
fcfe36b 
Includes the following:

* oneapi-src/unified-runtime#1653
* oneapi-src/unified-runtime#1568
* oneapi-src/unified-runtime#1634
* oneapi-src/unified-runtime#1669
ianayl pushed a commit to ianayl/sycl that referenced this pull request Jun 13, 2024
@kbenzie @ianayl
[UR] Bump main tag to f06bc02 (intel#14047)
52111a7 
Includes the following:

* oneapi-src/unified-runtime#1653
* oneapi-src/unified-runtime#1568
* oneapi-src/unified-runtime#1634
* oneapi-src/unified-runtime#1669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdelan hdelan hdelan approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Assignees
No one assigned
Labels
cuda CUDA adapter specific issues hip HIP adapter specific issues ready to merge Added to PR's which are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NVIDIA MultiGPU support for SYCL
5 participants
@JackAKirk @hdelan @steffenlarsen @kbenzie @npmiller