-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the test_valgrind.sh script running tests under valgrind #189
Conversation
@ldorau, the failures for |
But there are still some failures in
The reason is that the test fails under valgrind - but the failure is not a memory leak, we just fail on an assert. It looks like get_mempolicy() does not work under valgrind. |
3464460
to
9d62523
Compare
I will try to add suppressions for them. |
9d62523
to
7885043
Compare
And what about the failures with get_mempolicy? In the logs, I still see: Are we just going to ignore this? I don't really know why get_mempolicy does not work under valgrind. |
Yes, I would ignore that. The most important is that this test passes without valgrind. Apparently valgrind changes behavior of this test. We cannot help this. |
The valgrind (Nightly) build passes: https://github.com/oneapi-src/unified-memory-framework/actions/runs/7731094933/job/21077971238?pr=189 |
c15f2cc
to
c2093df
Compare
The corresponding Nightly CI job: https://github.com/ldorau/unified-memory-framework/actions/runs/7739459731 |
10d8310
to
abc4e35
Compare
LGTM |
abc4e35
to
df66c25
Compare
The current script just checks if there is the "ERROR SUMMARY: 0 errors from 0 contexts" line in the output of a test. It turned out that there can be many lines starting with "ERROR SUMMARY:" in the output of one test - some with errors and some without, so the current approach is wrong. We have to check if there are no other lines starting with "ERROR SUMMARY:" than this: "ERROR SUMMARY: 0 errors from 0 contexts" instead. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
df66c25
to
efd90d2
Compare
The current script just checks if there is the
"ERROR SUMMARY: 0 errors from 0 contexts"
line in the output of a test.
It turned out that there can be many lines starting with
"ERROR SUMMARY:" in the output of one test - some with
errors and some without, so the current approach is wrong.
We have to check if there are no other lines starting with
"ERROR SUMMARY:" than this:
"ERROR SUMMARY: 0 errors from 0 contexts" instead.