Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix growthbook chart ingress secret name #170

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Fix growthbook chart ingress secret name #170

merged 2 commits into from
Sep 13, 2023

Conversation

sivanchic
Copy link
Contributor

@sivanchic sivanchic commented Sep 6, 2023 •
edited
Loading

Proposed changes

This PR fixes the following issue: #161.
The ingress template has an unset variable for the secretName which is causing this problem.

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@sivanchic sivanchic marked this pull request as ready for review September 6, 2023 15:42
@sivanchic
Copy link
Contributor Author

@bisonlou @Yann-J @nzeugaa could you please take a look?

@bisonlou bisonlou merged commit fbcac81 into one-acre-fund:main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sivanchic @bisonlou