Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔖(2.3.0) Update version and CHANGELOG (#96) #98

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/publish-prerelease.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- run: npm ci
- run: npm run build

Expand All @@ -23,7 +23,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
registry-url: https://npm.pkg.github.com/
scope: '@onchain-id'
- run: npm ci
Expand All @@ -39,7 +39,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
registry-url: https://registry.npmjs.org/
scope: '@onchain-id'
- run: npm ci
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/publish-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- run: npm ci
- run: npm run build

Expand All @@ -23,7 +23,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
registry-url: https://npm.pkg.github.com/
scope: '@onchain-id'
- run: npm ci
Expand All @@ -39,7 +39,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
registry-url: https://registry.npmjs.org/
scope: '@onchain-id'
- run: npm ci
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/push_checking.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ jobs:
lint:
name: "Lint"
runs-on: ubuntu-latest
container: node:16
container: node:18

strategy:
matrix:
node-version: [16.x]
node-version: [18.x]

steps:
- uses: actions/checkout@v2
Expand All @@ -32,11 +32,11 @@ jobs:
test:
name: "Build and Test"
runs-on: ubuntu-latest
container: node:16
container: node:18

strategy:
matrix:
node-version: [16.x]
node-version: [18.x]

steps:
- uses: actions/checkout@v2
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [2.3.0]

### Changed
- Changed solidity compiler version to v0.8.24. Newer version of the compiler implements several gas and security related improvements. also compatible with latest version of @openzeppelin/contracts.
- Changed hardhat version to 2.21.0. This version of hardhat comes with ethers v6 which implements modern ES6 features, like ES2020 BigInt.

## [2.2.1]

### Changed
Expand Down
2 changes: 1 addition & 1 deletion contracts/ClaimIssuer.sol
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// SPDX-License-Identifier: GPL-3.0
pragma solidity 0.8.17;
pragma solidity 0.8.24;

import "./interface/IClaimIssuer.sol";

Check warning on line 4 in contracts/ClaimIssuer.sol

View workflow job for this annotation

GitHub Actions / Lint (18.x)

global import of path ./interface/IClaimIssuer.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
import "./Identity.sol";

Check warning on line 5 in contracts/ClaimIssuer.sol

View workflow job for this annotation

GitHub Actions / Lint (18.x)

global import of path ./Identity.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)

contract ClaimIssuer is IClaimIssuer, Identity {
mapping (bytes => bool) public revokedClaims;
Expand All @@ -14,7 +14,7 @@
* @dev See {IClaimIssuer-revokeClaimBySignature}.
*/
function revokeClaimBySignature(bytes calldata signature) external override delegatedOnly onlyManager {
require(!revokedClaims[signature], "Conflict: Claim already revoked");

Check warning on line 17 in contracts/ClaimIssuer.sol

View workflow job for this annotation

GitHub Actions / Lint (18.x)

Use Custom Errors instead of require statements

revokedClaims[signature] = true;

Expand All @@ -33,7 +33,7 @@

( foundClaimTopic, scheme, issuer, sig, data, ) = Identity(_identity).getClaim(_claimId);

require(!revokedClaims[sig], "Conflict: Claim already revoked");

Check warning on line 36 in contracts/ClaimIssuer.sol

View workflow job for this annotation

GitHub Actions / Lint (18.x)

Use Custom Errors instead of require statements

revokedClaims[sig] = true;
emit ClaimRevoked(sig);
Expand Down
2 changes: 1 addition & 1 deletion contracts/Identity.sol
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-3.0
pragma solidity 0.8.17;
pragma solidity 0.8.24;

import "./interface/IIdentity.sol";
import "./interface/IClaimIssuer.sol";
Expand Down
2 changes: 1 addition & 1 deletion contracts/Test.sol
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// SPDX-License-Identifier: GPL-3.0
pragma solidity 0.8.17;
pragma solidity 0.8.24;

contract Test {} // solhint-disable-line
2 changes: 1 addition & 1 deletion contracts/_testContracts/VerifierUser.sol
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* solhint-disable */

// SPDX-License-Identifier: GPL-3.0
pragma solidity 0.8.17;
pragma solidity 0.8.24;

import "../verifiers/Verifier.sol";

Expand Down
2 changes: 1 addition & 1 deletion contracts/factory/IIdFactory.sol
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-3.0
pragma solidity 0.8.17;
pragma solidity 0.8.24;

interface IIdFactory {

Expand Down
2 changes: 1 addition & 1 deletion contracts/factory/IdFactory.sol
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
// SPDX-License-Identifier: GPL-3.0
pragma solidity 0.8.17;
pragma solidity 0.8.24;

import "../proxy/IdentityProxy.sol";

Check warning on line 4 in contracts/factory/IdFactory.sol

View workflow job for this annotation

GitHub Actions / Lint (18.x)

global import of path ../proxy/IdentityProxy.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
import "./IIdFactory.sol";

Check warning on line 5 in contracts/factory/IdFactory.sol

View workflow job for this annotation

GitHub Actions / Lint (18.x)

global import of path ./IIdFactory.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
import "../interface/IERC734.sol";

Check warning on line 6 in contracts/factory/IdFactory.sol

View workflow job for this annotation

GitHub Actions / Lint (18.x)

global import of path ../interface/IERC734.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
import "@openzeppelin/contracts/access/Ownable.sol";

Check warning on line 7 in contracts/factory/IdFactory.sol

View workflow job for this annotation

GitHub Actions / Lint (18.x)

global import of path @openzeppelin/contracts/access/Ownable.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)

contract IdFactory is IIdFactory, Ownable {

mapping(address => bool) private _tokenFactories;

// address of the _implementationAuthority contract making the link to the implementation contract
address private immutable _implementationAuthority;

Check warning on line 14 in contracts/factory/IdFactory.sol

View workflow job for this annotation

GitHub Actions / Lint (18.x)

Immutable variables name are set to be in capitalized SNAKE_CASE

// as it is not possible to deploy 2 times the same contract address, this mapping allows us to check which
// salt is taken and which is not
Expand All @@ -32,7 +32,7 @@

// setting
constructor (address implementationAuthority) {
require(implementationAuthority != address(0), "invalid argument - zero address");

Check warning on line 35 in contracts/factory/IdFactory.sol

View workflow job for this annotation

GitHub Actions / Lint (18.x)

Use Custom Errors instead of require statements
_implementationAuthority = implementationAuthority;
}

Expand Down
2 changes: 1 addition & 1 deletion contracts/gateway/Gateway.sol
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-3.0
pragma solidity 0.8.17;
pragma solidity 0.8.24;

import "@openzeppelin/contracts/access/Ownable.sol";
import "@openzeppelin/contracts/utils/cryptography/ECDSA.sol";
Expand Down
2 changes: 1 addition & 1 deletion contracts/interface/IClaimIssuer.sol
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-3.0
pragma solidity 0.8.17;
pragma solidity 0.8.24;

import "./IIdentity.sol";

Expand Down
2 changes: 1 addition & 1 deletion contracts/interface/IERC734.sol
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-3.0
pragma solidity 0.8.17;
pragma solidity 0.8.24;

/**
* @dev interface of the ERC734 (Key Holder) standard as defined in the EIP.
Expand Down
2 changes: 1 addition & 1 deletion contracts/interface/IERC735.sol
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-3.0
pragma solidity 0.8.17;
pragma solidity 0.8.24;

/**
* @dev interface of the ERC735 (Claim Holder) standard as defined in the EIP.
Expand Down
2 changes: 1 addition & 1 deletion contracts/interface/IIdentity.sol
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-3.0
pragma solidity 0.8.17;
pragma solidity 0.8.24;

import "./IERC734.sol";
import "./IERC735.sol";
Expand Down
2 changes: 1 addition & 1 deletion contracts/interface/IImplementationAuthority.sol
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-3.0

pragma solidity 0.8.17;
pragma solidity 0.8.24;

interface IImplementationAuthority {

Expand Down
2 changes: 1 addition & 1 deletion contracts/proxy/IdentityProxy.sol
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-3.0

pragma solidity 0.8.17;
pragma solidity 0.8.24;

import "../interface/IImplementationAuthority.sol";

Expand Down
2 changes: 1 addition & 1 deletion contracts/proxy/ImplementationAuthority.sol
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-3.0

pragma solidity 0.8.17;
pragma solidity 0.8.24;

import "../interface/IImplementationAuthority.sol";
import "@openzeppelin/contracts/access/Ownable.sol";
Expand Down
2 changes: 1 addition & 1 deletion contracts/storage/Storage.sol
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-3.0
pragma solidity 0.8.17;
pragma solidity 0.8.24;
import "./Structs.sol";

contract Storage is Structs {
Expand Down
2 changes: 1 addition & 1 deletion contracts/storage/Structs.sol
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-3.0
pragma solidity 0.8.17;
pragma solidity 0.8.24;

contract Structs {

Expand Down
2 changes: 1 addition & 1 deletion contracts/verifiers/Verifier.sol
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-3.0

pragma solidity 0.8.17;
pragma solidity 0.8.24;

import "@openzeppelin/contracts/access/Ownable.sol";
import "../interface/IClaimIssuer.sol";
Expand Down
2 changes: 1 addition & 1 deletion contracts/version/Version.sol
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-3.0

pragma solidity 0.8.17;
pragma solidity 0.8.24;

/**
* @dev Version contract gives the versioning information of the implementation contract
Expand Down
2 changes: 1 addition & 1 deletion hardhat.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import "./tasks/remove-key.task";
import "./tasks/revoke.task";

const config: HardhatUserConfig = {
solidity: "0.8.17",
solidity: "0.8.24",
networks: {
mumbai: {
url: 'https://rpc-mumbai.maticvigil.com/v1/9cd3d6ce21f0a25bb8f33504a1820d616f700d24',
Expand Down
Loading
Loading