Adding notes #32
Adding notes #32
Conversation
latest from root
|
@pld note that export of notes is not implemented yet, not as straight forward I had initially thought. |
| @@ -4,3 +4,4 @@ | |||
| from xform import XForm | |||
| from odk_logger.xform_instance_parser import InstanceParseError | |||
| from ziggy_instance import ZiggyInstance | |||
| from .note import Note | |||
There was a problem hiding this comment.
suggest we use the full namespace here to keep it consistent with the other imports, and to make it clearer to devs
added KoBo to license
|
@pld made changes, please have a look |
Cleanup
…by one browse view
| from odk_viewer.models import ParsedInstance | ||
|
|
||
| from api.models import Project, OrganizationProfile, ProjectXForm, Team | ||
| from api.forms import NoteForm |
There was a problem hiding this comment.
I don't see this used anywhere in this file, is the import needed, is the api/forms.py file needed? Am I missing something about django?
There was a problem hiding this comment.
I first shifted the form to a separate file as suggested earlier, then when I started using the NoteSerializer I no longer had the need to use the form. So this should be removed, I will do that.
|
@ukanga this looks good, just a question about the form file. are exports in here? |
Adding notes, green, merge to keep things in sync
|
@pld exports are also covered in this pull request, a conversation with @larryweya made this way simler to implement 1fd1a00 |
|
Sound great, I merged the previous PR, is there a new one for removing that
|
Adding notes to a submission via api and via web form on instance view.