Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(docker): disable integration tests #122

Merged
merged 6 commits into from
Jun 12, 2024

Conversation

empwilli
Copy link
Contributor

No description provided.

empwilli added 4 commits June 11, 2024 15:24
Introduce the TEST_DOCKER_IMAGE environment variable for the docker integration
tests. This allows testers to select what image to use for tests.
Currently, we are not able to test the docker command from the test pipelines
w/o docker-cli. Hence, we disable the test for now.
We currently have no proper approach for testing the docker commands. Therefore,
we don't need the mock feature that has been introduced for these purposes in
the first place.
src/docker.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@mlilien mlilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR without Cargo.{toml|lock} version increment

@empwilli empwilli merged commit deb7db2 into omnect:main Jun 12, 2024
3 checks passed
@empwilli empwilli deleted the fix/disable_docker_tests branch June 20, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants