This repository has been archived by the owner on Feb 27, 2024. It is now read-only.
Fix sas token #21
Closed
Fix sas token #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bump to azure-iot-sdk 0.8.3
mlilien
approved these changes
Jul 20, 2022
JanZachmann
suggested changes
Jul 21, 2022
Comment on lines
+33
to
+43
| if let UnauthenticatedReason::ExpiredSasToken = reason { | ||
| info!("SAS Token expired, SDK will try to refresh the token automatically"); | ||
| } | ||
| else { | ||
| client.stop().await.unwrap(); | ||
| return Err(IotError::from(format!( | ||
| "No connection. Reason: {:?}", | ||
| reason | ||
| ))); | ||
| } | ||
|
|
There was a problem hiding this comment.
You can better write the following code. We don't need another log since it is logged already in SDK code
if !matches!(reason, UnauthenticatedReason::ExpiredSasToken) {
client.stop().await.unwrap();
return Err(IotError::from(format!(
"No connection. Reason: {:?}",
reason
)));
}
|
@JoergZeidler you can use my PR if you don't want to update yours: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JanZachmann : did not found a way to handle that condition with just and "if" condition. seems still open in rust? rust-lang/rfcs#2616