chore: remove some solhint workaround as latest version fixes the bug

Remove this comment: "// solhint-disable-next-line reason-string" as the issue is solved. solhint bug: protofire/solhint#157
omgnetwork · Oct 2, 2019 · 6ad717d · 6ad717d
1 parent 3c76b57
commit 6ad717d
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 12 deletions.
diff --git a/plasma_framework/contracts/mocks/exits/SpendingConditionMock.sol b/plasma_framework/contracts/mocks/exits/SpendingConditionMock.sol
@@ -50,8 +50,6 @@ contract SpendingConditionMock is ISpendingCondition {
         returns (bool)
     {
         if (shouldRevert) {
-            // TODO: solhint disabled for now due to bug, https://github.com/protofire/solhint/issues/157
-            // solhint-disable-next-line reason-string
             revert(REVERT_MESSAGE);
         }
 

diff --git a/plasma_framework/contracts/mocks/exits/StateTransitionVerifierMock.sol b/plasma_framework/contracts/mocks/exits/StateTransitionVerifierMock.sol
@@ -41,8 +41,6 @@ contract StateTransitionVerifierMock is IStateTransitionVerifier {
         returns (bool)
     {
         if (shouldRevert) {
-            // TODO: solhint disabled for now due to bug, https://github.com/protofire/solhint/issues/157
-            // solhint-disable-next-line reason-string
             revert("Failing on purpose");
         }
 

diff --git a/plasma_framework/contracts/src/exits/utils/TxFinalizationVerifier.sol b/plasma_framework/contracts/src/exits/utils/TxFinalizationVerifier.sol
@@ -25,12 +25,8 @@ contract TxFinalizationVerifier is ITxFinalizationVerifier {
         if (data.protocol == Protocol.MORE_VP()) {
             return checkInclusionProof(data);
         } else if (data.protocol == Protocol.MVP()) {
-            // TODO: solhint disabled for now due to bug, https://github.com/protofire/solhint/issues/157
-            // solhint-disable-next-line reason-string
             revert("not supporting MVP yet");
         } else {
-            // TODO: solhint disabled for now due to bug, https://github.com/protofire/solhint/issues/157
-            // solhint-disable-next-line reason-string
             revert("invalid protocol value");
         }
     }
@@ -44,12 +40,8 @@ contract TxFinalizationVerifier is ITxFinalizationVerifier {
         if (data.protocol == Protocol.MORE_VP()) {
             return data.txBytes.length > 0;
         } else if (data.protocol == Protocol.MVP()) {
-            // TODO: solhint disabled for now due to bug, https://github.com/protofire/solhint/issues/157
-            // solhint-disable-next-line reason-string
             revert("not supporting MVP yet");
         } else {
-            // TODO: solhint disabled for now due to bug, https://github.com/protofire/solhint/issues/157
-            // solhint-disable-next-line reason-string
             revert("invalid protocol value");
         }
     }