Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added attributes to linkPretty. #1115

Merged
merged 2 commits into from
Oct 31, 2017

Conversation

Daniel-KM
Copy link
Contributor

I added the possibility to add attributes to linkPretty(), like in link() and linkRaw().

I was wondering too if the default class resource-link should be added in all cases or not.

@zerocrates
Copy link
Member

Yeah, I think if we're going to allow custom attributes here, we want to force resource-link into the class at all times, since it's the backbone of the styling.

@Daniel-KM
Copy link
Contributor Author

Ok, I add it.

@zerocrates
Copy link
Member

Looks good to me; should allow this to be used in a couple situations it otherwise wouldn't work for.

@zerocrates zerocrates merged commit ad53745 into omeka:develop Oct 31, 2017
@Daniel-KM Daniel-KM deleted the feature/link_pretty_attributes branch October 31, 2017 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants