Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recheck new form names stuff #963

Closed
zerocrates opened this issue Jun 26, 2017 · 1 comment
Closed

Recheck new form names stuff #963

zerocrates opened this issue Jun 26, 2017 · 1 comment
Milestone

Comments

@zerocrates
Copy link
Member

Forms now have names in many places they didn't thanks to a Zend update, so we need to do some manual checking to see if some of our assumptions about the forms are still valid.

@zerocrates zerocrates modified the milestone: July 10 2017 Jun 26, 2017
zerocrates added a commit that referenced this issue Jul 10, 2017
zerocrates added a commit that referenced this issue Jul 10, 2017
@zerocrates
Copy link
Member Author

The name business comes from the usage of ElementFactory, which makes a little more sense to be making up names as it's really intended for elements.

The usual place this is a problem is with the CSRF auto-add element, because we have that depend on the form's name, if it has one (to avoid conflicts if multiple forms are printed on the same page).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant