Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets table width #1957

Open
allanaaa opened this issue Oct 11, 2022 · 4 comments
Open

Assets table width #1957

allanaaa opened this issue Oct 11, 2022 · 4 comments
Assignees

Comments

@allanaaa
Copy link

I uploaded an 1800x100 pixel banner and it's doing something untoward in the Assets table:

asset-width

It looks like .asset-entry img has max-heights but not max-widths. My command of flexbox is rusty but I think you could squish the image if there's a long filename, but not squish the filename or overflow the box if there's a wide image. Somehow....

@kimisgold kimisgold self-assigned this Oct 11, 2022
@allanaaa allanaaa changed the title Assets table with Assets table width Oct 11, 2022
kimisgold added a commit that referenced this issue Feb 8, 2023
@kimisgold
Copy link
Member

A fix is ready for testing.

@allanaaa
Copy link
Author

allanaaa commented Feb 9, 2023

This is fine. I don't love the max-width:50% on the images, I feel like squishing them even shorter than 48px is a bit of a waste of space. But it's an improvement for sure.
assets

@kimisgold
Copy link
Member

Hmm, I'm not sure I'm understanding your comment. How do you think space is wasted and did you have an alternative solution in mind?

@allanaaa
Copy link
Author

allanaaa commented Feb 9, 2023

For the really wide assets that still have lots of space left in their rows - mapbanner.jpg etc. - they're being compressed down to a point where you can't see much detail. I guess I would prefer something more of a compromise like this:

assets

But my CSS & flex are rusty so I may not be doing this the best way. Here's what it looks like:
assets

I turned off the max-width and put overflow:hidden on the .asset-entry img (not at all sure why that's working...), and put max-width:calc(100% - 72px) on the .asset-entry, to always leave space for the "actions" buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants