-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omeka S dies when trying to add too-large IIIF image #1193
Comments
PR #1194 fixes the crash. A more robust fix would detect the 403 response and fall back to a smaller version of the file; I’m not conversant enough with the IIIF API to implement that right now. |
#1193: quick patch to prevent crashing on too-large image
Yeah, we may need to switch to picking something out of My understanding is also that |
I may be missing something here, but one of the features of the IIIF Image API is that you can request images in smaller sizes, for example to use as thumbnails. So instead of downloading a full-size image and resizing it on the side of Omeka S, I would recommend to download a thumbnail-sized image. Or is that what you were saying, @zerocrates? |
So, the problem for us here is just that IIIF image servers can support various subsets of the spec features. The full/max size is (supposedly) guaranteed to be supported even by the lowest levels of compliance with the spec, so that's what we use. Obviously there's the idea that we could use the IIIF features themselves to get the size we want directly, but that resizing is not guaranteed to be available either. Some version of this that depended on the |
When importing an IIIF image, e.g. from here, Omeka S constructs a URL. If the image at that URL is larger than the allowed maximum, the IIIF server will return a 403 Forbidden response. Omeka S does not check for this, and when it tries to delete the temp file, it crashes.
The text was updated successfully, but these errors were encountered: