Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use getOwnerOmeName() instead of getOwnerOmeName. Error with Python 3.8 #6340

Merged
merged 1 commit into from
Jan 11, 2023
Merged

use getOwnerOmeName() instead of getOwnerOmeName. Error with Python 3.8 #6340

merged 1 commit into from
Jan 11, 2023

Conversation

jburel
Copy link
Member

@jburel jburel commented Jan 9, 2023

This matches the usage of the method in the other tests.
The tests fail when using Python 3.8

@jburel jburel requested a review from will-moore January 9, 2023 09:54
@will-moore
Copy link
Member

The changes look good 👍

The tests fail when using Python 3.8

Is that before this PR or with this PR?

@jburel
Copy link
Member Author

jburel commented Jan 9, 2023

The changes look good 👍

The tests fail when using Python 3.8

Is that before this PR or with this PR?

Before the PR.
Running the tests now

@jburel
Copy link
Member Author

jburel commented Jan 9, 2023

http://10.0.48.6:51234/job/OMERO-test-integration/86/ is now green
|I will check merge-ci tomorrow

@jburel jburel mentioned this pull request Jan 9, 2023
Open
sbesson
sbesson approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good although you might want to update the PR title which is a bit unspecific

@jburel jburel changed the title use the method. This fails using Python 3.8 use getOwnerOmeName() instead of getOwnerOmeName. Error with Python 3.8 Jan 9, 2023
@jburel
Copy link
Member Author

jburel commented Jan 11, 2023

https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-test-integration/1337/ is also green
Merging

@jburel jburel merged commit 0fcb15d into ome:develop Jan 11, 2023
@jburel jburel deleted the python_test branch March 10, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbesson sbesson sbesson approved these changes

@will-moore will-moore Awaiting requested review from will-moore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jburel @will-moore @sbesson