Fix units -> unit #131
Merged
Fix units -> unit #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbesson
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Sounds like we should schedule an immediate patch release to ensure the unit metadata is written correctly. Is https://github.com/ome/ome-zarr-py/releases/tag/v0.6.1 used anywhere as we probably want to avoid creating mixed data types as well?
|
👍 for getting this out ASAP. |
|
@sbesson I checked all the samples at https://idr.github.io/ome-ngff-samples/ for mixed dtypes but didn't see any. |
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ome/ngff#157
This is a corresponding fix to update all axes "units" to "unit" (as in the Spec).