Apply ruff rules to Python scripts #198
Conversation
52a38a2 to
735417e
Compare
There was a problem hiding this comment.
From an initial code review, I don't see concerning changes. Given the modifications to the code generation utilities, we'll need to confirm that the generated classes are unmodified by this change for all supported Python versions.
Several contributions are made against files of a package which has just been deprecated and are scheduled for removal in an upcoming release (setup.py, ome_model/experimental.py, test/unit/*) - see #194 for more details. Given the scope of this work, we might pioritize the clean up of these classes first and update you when this is completed and conflicts should be resolved so that only changes against xsd-fu utility are evaluated
735417e to
760ee8b
Compare
760ee8b to
120f7f1
Compare
|
@DimitriPapadopoulos with #206 merged, can you fix the conflicts on this PR by merging |
F401 imported but unused
E402 Module level import not at top of file
E703 Statement ends with an unnecessary semicolon
W291 Trailing whitespace
W293 Blank line contains whitespace
W391 Too many newlines at end of file
C414 Unnecessary `list()` call within `sorted()`
ISC002 Implicitly concatenated string literals over multiple lines
PIE790 Unnecessary `pass` statement
PIE810 Call `startswith` once with a `tuple`
SIM103 Return the condition directly
bool() is not required as the type of expressions is already bool
SIM110 Use `return any()` instead of `for` loop
SIM118 Use `key in dict` instead of `key in dict.keys()`
SIM401 Use `.get(...)` instead of an `if` block
FURB142 Use of `set.add()` in a for loop
FURB148 `enumerate` index is unused, use `for x in y` instead
UP003 Use `str` instead of `type(...)`
UP004 Class inherits from `object`
UP008 Use `super()` instead of `super(__class__, self)`
UP009 UTF-8 encoding declaration is unnecessary
UP024 Replace aliased errors with `OSError`
UP034 Avoid extraneous parentheses
120f7f1 to
2db8c35
Compare
|
Done |
|
Thanks. A diff of the Java classes generated by the |
There was a problem hiding this comment.
I generated and compared the output of mvn clean generated-sources executed using all supported Python versions (3.9, 3.10, 3.11, 3.12) against the same files generated from the current HEAD of this repository using Python 3.12.
In all cases, diff -r showed no difference and diff -rs confirmed the files were identical.
Most of the changes are related to code formatting and/or also modernization of some of the Python code from this utility. I'll leave @melissalinkert to take a look for anything of potential concern. Overall no objection to getting this in.
I'm assuming all scripts are Python 3 scripts, except this one:
specification/src/main/resources/transforms/util/write-transforms.py
The latter has been marked as a Python 2 script.