Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIOFORMATS-image: rotate between JDK versions #194

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented May 10, 2022

The JDK version used for building the Bio-Formats Docker image in the OME CI infrastructure is defined in https://github.com/ome/bio-formats-build/blob/master/Dockerfile#L1 and curently uses 8 as the minimal supported Java LTS version.

This commit allows to switch daily between LTS Java versions to increase our testing coverage. Currently the builds alternates between the supported 8 and 11 versions with 17 being a mid-term target.
In addition a first steps pulls the latest verison of the base image which should allow to avoid issues such as ome/bio-formats-build#241 (comment)

Currently deployed on https://merge-ci.openmicroscopy.org/jenkins/

@sbesson
Copy link
Member Author

sbesson commented Aug 29, 2022

@dgault @jburel while the background work on fully supporting JDK 17 probably needs extra time - see ome/bioformats#3815, this has been in the merge CI builds for the last four months. Should we get this merged as an intermediate step and update latest-ci so that the QA repository tests alternate between JDK 8 and JDK 11?

Copy link
Member

@jburel jburel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can always add new JDK version to the testing matrix

@sbesson sbesson merged commit f3faac7 into ome:master Aug 30, 2022
@sbesson sbesson deleted the BIOFORMATS-image_jdk_rotation branch August 30, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants