Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make private Pattern field transient #3796

Merged
merged 1 commit into from
May 19, 2022

Conversation

melissalinkert
Copy link
Member

See glencoesoftware/bioformats2raw#139 (comment)

Using Java 17 without this PR:

$ cat test.pattern
test_c<1-3>.fake
$ showinf -cache test.pattern
...
failed to save memo file: /Users/melissa/test-case/.test.pattern.bfmemo
...

The same test with this PR should successfully save the memo file.

Technically breaks memo files (to fix them!), so probably not OK for a patch release.

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A run of the automated tests against our curated cellomics datasets with JDK17 indicates all tests are passing including the memo file generation/reloading.

It looks unlikely that Bio-Formats will be successfully tested on JDK 17 across all file formats by the time we are ready to release Bio-Formats 6.10.0. As we are going for a minor release and this PR invalidate cache files, it feels safe enough to include as a first step.

@dgault dgault merged commit e8ad930 into ome:develop May 19, 2022
@melissalinkert melissalinkert deleted the java-internal-serialization branch September 6, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants