Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderToString #47

Closed
si14 opened this issue Jan 7, 2014 · 7 comments
Closed

renderToString #47

si14 opened this issue Jan 7, 2014 · 7 comments

Comments

@si14
Copy link

si14 commented Jan 7, 2014

renderToString of components should be very useful for server-side rendering.

@pavlo-v-chernykh
Copy link

👍

@swannodette
Copy link
Member

Yep this will likely land before I cut 0.1.6.

@swannodette
Copy link
Member

Turns out in order for this to work a bug in React must be addressed first - facebook/react#860

@hura
Copy link

hura commented Feb 11, 2014

FWIW, still doesn't work with the latest React (4974734)

(.renderComponentToString js/React (dom/p nil))
; <p data-reactid=\".q\" data-react-checksum=\"1813907431\"></p>
(.renderComponentToString js/React (dom/input nil))
; Cannot read property 'firstChild' of undefined

Though, the bug you filed seems to be resolved.

This would be really useful to RDD.

@swannodette
Copy link
Member

@hura I could not confirm this. It works for me using React master.

@swannodette
Copy link
Member

Fixed in master and works with React 0.9-rc1. There are somer remaining edge cases but overall this works.

@CatTail
Copy link

CatTail commented Feb 9, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants