React.renderComponentToString failing case when component children is a function

[swannodette]

var Hello = React.createClass({
    componentDidMount: function() {},
    render: function() {
        return this.props.children();
    }
});

React.renderComponentToString(
    Hello(null, function() { return React.DOM.div(null, "Hello"); }), 
    function(s) { console.log(s); }
);

Results in:

Uncaught TypeError: Cannot read property 'firstChild' of undefined 

[vjeux]

JSFiddle: http://jsfiddle.net/vjeux/E8gCL/

[vjeux]

Reduced to

var Hello = React.createClass({
    render: function() {
        return this.props.children;
    }
});

React.renderComponentToString(
    Hello(null, React.DOM.div(null, "Hello")), 
    function(s) { console.log(s); }
);

http://jsfiddle.net/vjeux/E8gCL/1/

[sophiebits]

@vjeux Your last fiddle doesn't repro the problem for me; the componentDidMount is significant.

[vjeux]

@spicyj : Woops you are right, I rushed the comment :( http://jsfiddle.net/vjeux/E8gCL/2/

[plievone]

Breaks on 0.8.0 on browser only, but not on master for me. (Noticed the breaking with componentDidMount some time ago but didn't file an issue as perhaps there had been an issue already)

[petehunt]

I have a fix for this

[plievone]

@petehunt But those fiddles seem to work ok on current master?

[petehunt]

The fix is for the somewhat related putListener() memory leak

[sophiebits]

I believe this was fixed by e73900d.

[swannodette]

I haven't had a chance to verify myself but according to an Om user this issue is still not fixed. omcljs/om#47, they tested with a recent React commit 4974734

[sophiebits]

Well, http://jsfiddle.net/E8gCL/4/ works for me now.

[sophiebits]

(Filed #1079 which is probably the underlying cause even though the symptoms here changed.)

[swannodette]

I've confirmed that this is no longer a problem in Om w/ React master.

[sophiebits]

@swannodette This works for you?

(.renderComponentToString js/React (dom/input nil))

[swannodette]

@spicyj actually that does not work. But the custom component cases work.