Skip to content

Commit

Permalink
refactor: remove user todos (GoogleCloudPlatform#1977)
Browse files Browse the repository at this point in the history
Remove assignee thiagotnunes for PostgreSQL type mappings TODOs.
  • Loading branch information
thiagotnunes authored Nov 11, 2024
1 parent cb9b943 commit 1bef5ff
Showing 1 changed file with 7 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,21 +38,21 @@ public final class PostgreSQLMappingProvider {
.put("BOOL", UnifiedMappingProvider.Type.BOOLEAN)
.put("BOOLEAN", UnifiedMappingProvider.Type.BOOLEAN)
.put("BYTEA", UnifiedMappingProvider.Type.BYTES)
// TODO(thiagotnunes): Refine mapping type according to
// TODO: Refine mapping type according to
// https://cloud.google.com/datastream/docs/unified-types#map-psql (if there is a limit
// for length we should use varchar instead)
.put("CHAR", UnifiedMappingProvider.Type.STRING)
// TODO(thiagotnunes): Refine mapping type according to
// TODO: Refine mapping type according to
// https://cloud.google.com/datastream/docs/unified-types#map-psql (if there is a limit
// for length we should use varchar instead)
.put("CHARACTER", UnifiedMappingProvider.Type.STRING)
// TODO(thiagotnunes): Refine mapping type according to
// TODO: Refine mapping type according to
// https://cloud.google.com/datastream/docs/unified-types#map-psql (if there is a limit
// for length we should use varchar instead)
.put("CHARACTER VARYING", UnifiedMappingProvider.Type.STRING)
.put("CITEXT", UnifiedMappingProvider.Type.STRING)
.put("DATE", UnifiedMappingProvider.Type.DATE)
// TODO(thiagotnunes): Refine mapping type according to
// TODO: Refine mapping type according to
// https://cloud.google.com/datastream/docs/unified-types#map-psql (if there is a
// precision and scale are >= 0, map to DECIMAL)
.put("DECIMAL", UnifiedMappingProvider.Type.NUMBER)
Expand All @@ -67,6 +67,7 @@ public final class PostgreSQLMappingProvider {
.put("JSON", UnifiedMappingProvider.Type.JSON)
.put("JSONB", UnifiedMappingProvider.Type.JSON)
.put("MONEY", UnifiedMappingProvider.Type.DOUBLE)
// TODO: Refine mapping type according to
// https://cloud.google.com/datastream/docs/unified-types#map-psql (if there is a
// precision and scale are >= 0, map to DECIMAL)
.put("NUMERIC", UnifiedMappingProvider.Type.NUMBER)
Expand All @@ -78,7 +79,7 @@ public final class PostgreSQLMappingProvider {
.put("SERIAL8", UnifiedMappingProvider.Type.LONG)
.put("SMALLINT", UnifiedMappingProvider.Type.INTEGER)
.put("SMALLSERIAL", UnifiedMappingProvider.Type.INTEGER)
// TODO(thiagotnunes): Refine mapping type according to
// TODO: Refine mapping type according to
// https://cloud.google.com/datastream/docs/unified-types#map-psql (if there is a limit
// for length we should use varchar instead)
.put("TEXT", UnifiedMappingProvider.Type.STRING)
Expand All @@ -88,7 +89,7 @@ public final class PostgreSQLMappingProvider {
.put("TIMESTAMP WITHOUT TIME ZONE", UnifiedMappingProvider.Type.TIMESTAMP)
.put("UUID", UnifiedMappingProvider.Type.STRING)
.put("VARBIT", UnifiedMappingProvider.Type.BYTES)
// TODO(thiagotnunes): Refine mapping type according to
// TODO: Refine mapping type according to
// https://cloud.google.com/datastream/docs/unified-types#map-psql (if there is a limit
// for length we should use varchar instead)
.put("VARCHAR", UnifiedMappingProvider.Type.STRING)
Expand Down

0 comments on commit 1bef5ff

Please sign in to comment.