Updated sanity checks for statements #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2fcb856 to
785dc48
Compare
3fc266f to
038c4d6
Compare
veluca93
approved these changes
Dec 29, 2024
| @@ -12,6 +12,69 @@ use crate::ioi::{IOITask, SubtaskId}; | |||
| use crate::sanity_checks::{make_sanity_check, SanityCheck, SanityCheckCategory}; | |||
| use crate::EvaluationData; | |||
|
|
|||
| const LANGUAGES: [&str; 60] = [ | |||
There was a problem hiding this comment.
Comment that the list is taken from cms?
| @@ -405,6 +464,17 @@ fn extract_subtasks(path: &Path, tex: &str) -> Option<Vec<ExtractedSubtask>> { | |||
| .or_else(|| check_subtasks_ois(path, tex)) | |||
| } | |||
|
|
|||
| fn relatively_resolve_symlink(path: &Path) -> Result<PathBuf, Error> { | |||
There was a problem hiding this comment.
I'd just drop the "relatively_" here
| while new_path.is_symlink() { | ||
| new_path = new_path.read_link()?; | ||
| if new_path == path { | ||
| bail!("Circular symbolic links detected"); |
There was a problem hiding this comment.
This doesn't work for...
luca@xps /tmp $ ls -l a b
lrwxrwxrwx 1 luca luca 1 Dec 29 19:19 a -> b
lrwxrwxrwx 1 luca luca 1 Dec 29 19:19 b -> a
I'd just put a depth limit.
veluca93
approved these changes
Dec 29, 2024
veluca93
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #267.