Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(completion): Boost score of blink completion suggestions #596

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

schilkp
Copy link
Contributor

@schilkp schilkp commented Jan 5, 2025

Description

By default, blink's path provider has a score offset of 3, meaning that completions for slash commands in the buffer are deep down below possible path completions in the list of suggestions.

Since this suggestion only triggers in the chat buffer, it is reasonable to assume that slashcommands are much more likely to be the correct suggestions than folders at /.

Screenshots

Before:
image

After:
image

Checklist

  • I've read the CONTRIBUTING guidelines and have adhered to them in this PR
  • I've updated the README
  • I've ran the make docs command

schilkp and others added 2 commits January 5, 2025 21:20
By default, blink's `path` provider has a score offset of 3, meaning
that completions for slash commands in the buffer are deep down
below possible path completions in the list of suggestions.

Since this suggestion only triggers in the chat buffer, it is reasonable
to assume that slashcommands are much more likely to be the correct
suggestions than folders at `/`.
@olimorris
Copy link
Owner

Amaaaaazing! Such a good idea. Anything obvious I miss with blink, please do PR it.

@olimorris olimorris merged commit 4317513 into olimorris:main Jan 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants