[nvidia-bluefield] Add support for new "nvidia-bluefield" platform. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivekrnv
reviewed
Mar 20, 2024
| # | ||
|
|
||
| BF_ASSETS_GITHUB_REPO = nvidia-sonic/sonic-bluefield-packages | ||
| SDK_ASSETS_GITHUB_TOKEN = |
There was a problem hiding this comment.
How do we plan to handle this, shouldn't we be hosting these packages in a public repo instead?
There was a problem hiding this comment.
Yes, I'm working on moving releases to the public repository.
vivekrnv
approved these changes
Mar 20, 2024
Yakiv-Huryk
reviewed
Mar 25, 2024
|
|
||
| def get_bf_version(self): | ||
| bf2_platforms = ['Nvidia-MBF2H536C'] | ||
| return BFVersion.BF2 if self.get_platform_name() in bf2_platforms else BFVersion.BF3 |
Yakiv-Huryk
reviewed
Mar 25, 2024
| raise ImportError (str(e) + "- required module not found") | ||
|
|
||
| def initialize_chassis_thermals(bfversion): | ||
| if bfversion == BFVersion.BF3: |
There was a problem hiding this comment.
if we don't support BF2, maybe it's better to remove BFVersion and these checks altogether?
Signed-off-by: Oleksandr Ivantsiv <oivantsiv@nvidia.com> Co-authored-by: Vivek Reddy <vkarri@nvidia.com> Co-authored-by: Yakiv Huryk <yhuryk@nvidia.com>
1c234e8 to
dc2b7dc
Compare
oleksandrivantsiv
pushed a commit
that referenced
this pull request
Jul 15, 2024
…tically (sonic-net#19459) #### Why I did it src/sonic-dash-api ``` * 5809048 - (HEAD -> master, origin/master, origin/HEAD) [build]Update pool sonicbld to sonic-ububtu-1c since it's deprecated (#21) (10 days ago) [Jianquan Ye] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)