Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor "Devices" tab from List to Table from SwiftUI #84

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Refactor "Devices" tab from List to Table from SwiftUI #84

merged 5 commits into from
Oct 31, 2023

Conversation

jaworek
Copy link
Contributor

@jaworek jaworek commented Oct 29, 2023 •
edited
Loading

Resolves #54.

Video recording showing new implementation:

Screen.Recording.Oct.29.mov

okwasniewski
okwasniewski reviewed Oct 29, 2023
View reviewed changes
Copy link
Owner

@okwasniewski okwasniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! I've left few minor comments

MiniSim/Views/ParametersTable/ParametersTable.swift Outdated Show resolved Hide resolved
MiniSim/Views/ParametersTable/ParametersTable.swift Outdated Show resolved Hide resolved
MiniSim/Views/ParametersTable/ParametersTableForm.swift Outdated Show resolved Hide resolved
MiniSim/Views/ParametersTable/ParametersTableViewModel.swift Outdated Show resolved Hide resolved
MiniSim/Views/ParametersTable/ParametersTableViewModel.swift Outdated Show resolved Hide resolved
@jaworek
Copy link
Contributor Author

jaworek commented Oct 29, 2023

Thanks for the quick review! I've addressed all suggestions :D

okwasniewski
okwasniewski reviewed Oct 30, 2023
View reviewed changes
Copy link
Owner

@okwasniewski okwasniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I launched the example files weren't added to Xcode (they were on disk) did you push the changes in project.pbxproj?

MiniSim/Views/ParametersTable/ParametersTable.swift Outdated Show resolved Hide resolved
MiniSim/Views/ParametersTable/ParametersTableForm.swift Outdated Show resolved Hide resolved
okwasniewski
okwasniewski approved these changes Oct 31, 2023
View reviewed changes
Copy link
Owner

@okwasniewski okwasniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks for this! 🙏

@okwasniewski okwasniewski merged commit 191982c into okwasniewski:main Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okwasniewski okwasniewski okwasniewski approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor ParametersTable component to Table
2 participants
@jaworek @okwasniewski