Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: delete android emulator #104

Merged
merged 3 commits into from
Nov 20, 2023
Merged

feature: delete android emulator #104

merged 3 commits into from
Nov 20, 2023

Conversation

gokul1099
Copy link
Contributor

This pull request introduces the ability to delete emulators. #89
Users can now delete both active(running) emulator and inactive emulators.

Please provide you feedback @okwasniewski

okwasniewski
okwasniewski reviewed Nov 20, 2023
View reviewed changes
Copy link
Owner

@okwasniewski okwasniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR! It looks good, there are a few minor issues reported by SwiftLint like: "Trailing Whitespace Violation: Lines should not have trailing whitespace".

Can you fix them and we will be good to merge?

MiniSim/MenuItems/SubMenuItem.swift Outdated Show resolved Hide resolved
@okwasniewski okwasniewski force-pushed the feat_delete_android_emulator branch from f9de7a4 to 4b82b0e Compare November 20, 2023 15:53
okwasniewski
okwasniewski approved these changes Nov 20, 2023
View reviewed changes
Copy link
Owner

@okwasniewski okwasniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@okwasniewski okwasniewski merged commit 8075092 into okwasniewski:main Nov 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okwasniewski okwasniewski okwasniewski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gokul1099 @okwasniewski