Add argument/env var to set the session expiry for the AWS credentials. #14
Conversation
There was a problem hiding this comment.
@tim-fitzgerald I love this PR. Making the token's ttl configurable was on my TODO list. Thanks for getting that work done.
I do think there are unintended consequences on the HEADDOC-like formatting of help output with the string literals that need to be corrected.
| Okta authentication for federated identity providers in support of AWS CLI. | ||
| okta-aws-cli handles authentication to the IdP and token exchange with AWS STS | ||
| to collect a proper IAM role for the AWS CLI operator.`, | ||
|
|
There was a problem hiding this comment.
@tim-fitzgerald did you intend to indent the output one character? I think your editor got opinionated on formatting, adding extra white space to blank lines, adding tab characters, and throwing off the sprintf. I use VSCode and I've had to deal with this in HEREDOC-like formatting.
This occurs in cobra command Long value Long is the long message shown in the 'help <this-command>' output. and in resourceUsageTemplate()
Here is the after, note the indentation on help and the dangling % which I think is from a mismatched sprintf
After:
Before:
There was a problem hiding this comment.
go run cmd/okta-aws-cli/main.go --help
|
@monde thanks Mike! Yup overzealous VSCode formatting that I didn't notice. Have reverted those erroneous formatting changes. |
This change allows the user to set the expiration time for the AWS credentials retrieved by
okta-aws-cli.