Correct evaluation of "profile" command argument #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viper config library was already doing this but profile is treated in a special case as the CLI flag is `--profile` but the ENV VAR name is `OKTA_AWSCLI_PROFILE` so as not clobber `PROFILE` that may be set by other environments. Clarify order precedence of CLI flag > .env val > ENV VAR Closes #120
ac51e1b to
9eb2c7c
Compare
duytiennguyen-okta
approved these changes
Aug 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure "profile" flag/env var is evaluated in the same order as AWS CLI. Viper config library was already doing this but profile is treated in a special case as the CLI flag is
--profilebut the ENV VAR name isOKTA_AWSCLI_PROFILEso as not clobberPROFILEthat may be set by other environments.Clarify order precedence of CLI flag > .env val > ENV VAR
Closes #120