Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AttributeError when comparing non-Erlang objects to Erlang object… #9

Closed
wants to merge 3 commits into from
Closed

Fix AttributeError when comparing non-Erlang objects to Erlang object… #9

wants to merge 3 commits into from

Conversation

nickeldan
Copy link

…s. Move common class methods into base class.

…s. Move common class methods into base class.
@nickeldan nickeldan closed this May 11, 2022
@nickeldan nickeldan reopened this May 11, 2022
@nickeldan
Copy link
Author

The check failure may be due to this issue in setuptools.

@okeuday
Copy link
Owner

okeuday commented May 11, 2022

@nickeldan Python inheritance is avoided to ensure errors are caught in an explicit way during runtime, despite having a common interface (if it was a programming language with static typing and compile-time type checking, the situation would be different, mypy exists for newer Python 3 versions but is unable to catch every possible problem as an external static analysis tool). There isn't a good backwards compatible (Python 2/3) way to do a pure virtual method (it would make the source code worse if it was possible). For these reasons it is best to not pursue these changes.

@okeuday okeuday closed this May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants