Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address infinite loop when fetching events #2544

Merged
merged 6 commits into from
Jan 27, 2025
Merged

Address infinite loop when fetching events #2544

merged 6 commits into from
Jan 27, 2025

Conversation

corrideat
Copy link
Member

No description provided.

@corrideat corrideat self-assigned this Jan 24, 2025
@corrideat corrideat linked an issue Jan 24, 2025 that may be closed by this pull request
Deadlock on syncing logged in identity contract #2542
Closed
@corrideat corrideat requested a review from taoeffect January 24, 2025 22:25
@cypress Cypress
Copy link

cypress bot commented Jan 24, 2025 •
edited
Loading

group-income    Run #3805

Run Properties:  status check passed Passed #3805  •  git commit 6982bc38d2 ℹ️: Merge b32279a70957cbd07f840ee0bf7acdc8fd996c86 into 4b8263d115b76ce7ba9d3c22ca33...
Project group-income
Branch Review 2542-deadlock-on-syncing-logged-in-identity-contract
Run status status check passed Passed #3805
Run duration 11m 00s
Commit git commit 6982bc38d2 ℹ️: Merge b32279a70957cbd07f840ee0bf7acdc8fd996c86 into 4b8263d115b76ce7ba9d3c22ca33...
Committer Ricardo Iván Vieitez Parra
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 112
View all changes introduced in this branch ↗︎

@corrideat corrideat force-pushed the 2542-deadlock-on-syncing-logged-in-identity-contract branch from 193840f to b6e8a9d Compare January 25, 2025 13:17
@corrideat corrideat marked this pull request as ready for review January 25, 2025 13:19
taoeffect
taoeffect reviewed Jan 26, 2025
View reviewed changes
frontend/main.js Outdated Show resolved Hide resolved
taoeffect
taoeffect reviewed Jan 26, 2025
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
taoeffect
taoeffect requested changes Jan 26, 2025
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @corrideat!

Review ready!

taoeffect
taoeffect reviewed Jan 27, 2025
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
@corrideat corrideat force-pushed the 2542-deadlock-on-syncing-logged-in-identity-contract branch from 15ced55 to b32279a Compare January 27, 2025 18:14
taoeffect
taoeffect approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@taoeffect taoeffect merged commit cbe37a1 into master Jan 27, 2025
4 checks passed
@taoeffect taoeffect deleted the 2542-deadlock-on-syncing-logged-in-identity-contract branch January 27, 2025 18:52
@taoeffect taoeffect mentioned this pull request Jan 27, 2025
Closed
corrideat added a commit that referenced this pull request Jan 28, 2025
@corrideat
Close #2544
4d6888b
corrideat added a commit that referenced this pull request Jan 28, 2025
@corrideat
Close #2544
d72bf0e
taoeffect pushed a commit that referenced this pull request Jan 28, 2025
@corrideat
Close #2553 (#2555)
34156c8 
* Close #2544

* ChatMain additional checks

* Add nonReactive key

* Use reference object after isSyncing check

* Add consistency check

* Fixes

* Empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoeffect taoeffect taoeffect approved these changes

Assignees

@corrideat corrideat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deadlock on syncing logged in identity contract
2 participants
@corrideat @taoeffect