Wait for Chelonia, more error logs #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78f539f to
4250b55
Compare
group-income
|
||||||||||||||||||||||||||||
| Project |
group-income
|
| Branch Review |
2469-missing-pubsub-instance-bug-and-failure-to-recover-pubsub-connection
|
| Run status |
|
| Run duration | 11m 40s |
| Commit |
|
| Committer | Ricardo Iván Vieitez Parra |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
111
|
| View all changes introduced in this branch ↗︎ | |
4250b55 to
b4d04e3
Compare
taoeffect
reviewed
Dec 18, 2024
taoeffect
reviewed
Dec 18, 2024
Comment on lines
+54
to
+81
| // Send a 'ready' message to the SW and wait back for a response | ||
| // This way we ensure that Chelonia has been set up | ||
| await new Promise((resolve, reject) => { | ||
| const messageChannel = new MessageChannel() | ||
| messageChannel.port1.onmessage = (event) => { | ||
| if (event.data.type === 'ready') { | ||
| resolve() | ||
| } else { | ||
| reject(event.data.error) | ||
| } | ||
| messageChannel.port1.close() | ||
| } | ||
| messageChannel.port1.onmessageerror = () => { | ||
| reject(new Error('Message error')) | ||
| messageChannel.port1.close() | ||
| } | ||
|
|
||
| navigator.serviceWorker.ready.then((worker) => { | ||
| worker.active.postMessage({ | ||
| type: 'ready', | ||
| port: messageChannel.port2 | ||
| }, [messageChannel.port2]) | ||
| }).catch((e) => { | ||
| reject(e) | ||
| messageChannel.port1.close() | ||
| }) | ||
| }) | ||
|
|
There was a problem hiding this comment.
This seems like boilerplate we could abstract away in a function somewhere.
Can you create a function so that chunk is shortened like so?
await postWorkerMessage(worker, { type: 'ready' })And if there are any other parts of the app that also do something like this, they can reuse this function.
There was a problem hiding this comment.
I could make it into another function, but this particular message is unique in how it's sent, that it expects a response and that it expects a response (sbp also expects a response, but is handled by a more general-purpose function)
There was a problem hiding this comment.
It's also not entirely general purpose because the handler for onmessage is custom
taoeffect
reviewed
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2469.
This PR adds more logging to catch Chelonia set up errors, and it adds logic to check that Chelonia has been setup.