-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2411 - Compress large images attached in the chat #2428
Merged
taoeffect
merged 11 commits into
master
from
sebin/task/#2411-compress-images-before-uploading
Dec 2, 2024
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
eccdb45
determine if an image needs compression or not
SebinSong 4511cef
implement compressImage() function
SebinSong 59e92d9
write a function that checks if image/webp format is supported
SebinSong 0866b47
implement recursive compression logic in compressImage()
SebinSong d4712f9
optimise compression factors / some corrections on file details post …
SebinSong 342892a
update the minimum quality
SebinSong 657ff07
fix the typo iamge
SebinSong db4564d
do not resize the image unless its physical size is too large
SebinSong 1cb398e
update maximum image dimension
SebinSong d4eac04
remove console.log / revert back webP format as default
SebinSong 1985f28
add a constant for kilo-byte
SebinSong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the multiple tests I've done, when the quality factor value passed to
canvas.toBlob()
becomes<= 0.3
, the outcome image starts to lose the quality to an unpleasant level.0.3
here is a value I chose subjectively, but feel free to try compression test yourself using this codepen I created for this task and let me know if you would like a change.