#2356 - Fix the chat markdown bug related to a line-break #2361
Conversation
| .replace(/<br>\n(\s*)(\d+\.|-)/g, '\n\n$1$2') // [1] custom-handling the case where <br> is directly followed by the start of ordered/unordered lists | ||
| .replace(/(\d+\.|-)(\s.+)\n<br>/g, '$1$2\n\n') // [2] this is a custom-logic added so that the end of ordered/un-ordered lists are correctly detected by markedjs. |
There was a problem hiding this comment.
As inline-commented in the same file, markedjs with gfm style has a default behaviour where it collapses multiple consecutive line-breaks into one which is not what we want for the app. [1] and [2] here are the custom logics added to work around this. But [2] here didn't capture an edge-case where the last-child of a list ends with <code> element.
(The reason for this edge case is that, we split the whole text by markdown code elements first before applying these [1] and [2] because no content wrapped within <code>...</code> should be converted. eg. we already made a fix before for a bug where something like a<=b within <code> element looks incorrect.)
So added a fix in L51 below to take this into account.
group-income
|
||||||||||||||||||||||||||||
| Project |
group-income
|
| Branch Review |
sebin/task/#2356-markdown-linebreak-bug
|
| Run status |
|
| Run duration | 09m 27s |
| Commit |
|
| Committer | Sebin Song |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
111
|
| View all changes introduced in this branch ↗︎ | |
closes #2356
Screenshot for the fix.
