-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2309: Add badge on mobile if there is an unread message #2324
Conversation
group-income
|
Project |
group-income
|
Branch Review |
task/#2309-new-design-on-mobile-chat
|
Run status |
|
Run duration | 09m 22s |
Commit |
|
Committer | Pierre Schweiger |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
10
|
|
0
|
|
111
|
View all changes introduced in this branch ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another issue is that the badge appears to be floating around, so it's not immediately obvious that it's part of the button. |
I've updated the logic: I've updated the icon design to have a background attached to the notification, so the badge is not floating anymore, but attached to the button. If there is already notification for something else, the main menu show that notification. When the user open the menu he can either look at the notification but also can see that there is a new message in the chat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working, nice work @pieer!
No description provided.