#2305 Implement in-app notifications for non-monetary contributions #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
group-income
|
||||||||||||||||||||||||||||
| Project |
group-income
|
| Branch Review |
sebin/task/#2305-notifications-for-non-monetary
|
| Run status |
|
| Run duration | 09m 13s |
| Commit |
|
| Committer | Sebin Song |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
111
|
| View all changes introduced in this branch ↗︎ | |
snowteamer
reviewed
Aug 21, 2024
frontend/model/contracts/group.js
Outdated
| @@ -1791,6 +1812,30 @@ sbp('chelonia/defineContract', { | |||
| }).catch(e => { | |||
| console.warn(`removeForeignKeys: ${e.name} error thrown:`, e) | |||
| }) | |||
| }, | |||
| 'gi.contracts/group/sendNonMonetaryUpdateNontification': ({ | |||
There was a problem hiding this comment.
Typo here: -Nontification
There was a problem hiding this comment.
@snowteamer good catch, fixed.
|
This PR is ready besides the group-chat heisen-bug |
|
Thanks @SebinSong. Supposedly @corrideat thinks his PR #2294 (once it's ready) should address the heisenbug. |
…tifications-for-non-monetary
…tifications-for-non-monetary
…tifications-for-non-monetary
…tifications-for-non-monetary
…tifications-for-non-monetary
taoeffect
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2305
Currently there is two places where users can add/remove/update their non-monetary contributions:
1.
/contributionspage.2.
IncomeDetails.vuemodal.In 1., the item is added/removed/updated one by one. Whereas in 2., multiple items can be added/removed/updated at a time. In this case, the notification sentence can have compound expressions (not sure if this is a correct english words but anyways) eg.
Teach Javascript and 2 moreoradded Teach Python and removed Teach how to play piano and 1 moreetc.Clicking on the notification messages navigates to
/contributionspage where they can see the full list of the group's non-monetary contributions.Hope it looks good.