Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in making notification body #2221

Conversation

Silver-IT
Copy link
Member

@Silver-IT Silver-IT requested a review from taoeffect July 18, 2024 06:01
@Silver-IT Silver-IT self-assigned this Jul 18, 2024
Copy link

cypress bot commented Jul 18, 2024

Passing run #2724 ↗︎

0 112 10 0 Flakiness 0

Details:

Merge 8872e2e into 2113f66...
Project: group-income Commit: f0777b32a5 ℹ️
Status: Passed Duration: 10:52 💡
Started: Jul 18, 2024 11:32 PM Ended: Jul 18, 2024 11:42 PM

Review all test suite changes for PR #2221 ↗︎

Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Silver-IT! One issue found:

frontend/model/notifications/templates.js Outdated Show resolved Hide resolved
@taoeffect taoeffect merged commit eeea0d4 into master Jul 19, 2024
4 checks passed
@taoeffect taoeffect deleted the 2189-missing-identity-contract-of-group-members-who-are-already-left-from-the-group branch July 19, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing identity contract of group members who are already left from the group
2 participants