Fix errors in switching chatroom when user leaves group or chatroom

[Silver-IT]

Summary of Changes

• Closes Switching chatroom doesn't work when the user leaves it #2185

[cypress]

Passing run #2694 ↗︎

0

114

8

0

0

Details:

Merge 6dec75b into f73ce63...
Project: group-income	Commit: f83c034910 ℹ️
Status: Passed	Duration: 10:44 💡
Started: Jul 18, 2024 1:36 AM	Ended: Jul 18, 2024 1:47 AM

Review all test suite changes for PR #2186 ↗︎

[taoeffect]

A minor comment improvement and a question

[taoeffect]

Great work @Silver-IT!

I left a comment here for a minor change request.

I also found a serious bug:

I decided to test leaving a chatroom voluntarily and being kicked out of the chatroom to see if both worked.

• To do this, I created a group with two users, u1 and u2.
• I had each user create two chatrooms, so 4 chatrooms in total.
• Then, each user added the other user to the chatrooms they created.
• Next, for each of the chatrooms each user created, I kicked the other user out of one of the chatrooms, and had the other user leave voluntarily.
• Finally, in separate session tabs, I had both users log in (so u1 is logged in to [Tab1] and [Tab3] and u2 is logged in to [Tab2] and [Tab4]

I started to record toward the end of this, and you can see the result:

When the users left the chartroom voluntarily, this resulted in an error when they logged back in on a new fresh session tab.

[chelonia/contract/release] Invalid negative reference count for z9brRu3VKg2ifBpQHXqLZyCa3aqw5Kv397h2XECS2com8ug8dQM4 [captureLogs.js:36:30](http://localhost:3000/frontend/model/captureLogs.js)
[leaveChatRoomAction] Error releasing chatroom z9brRu3VKg2ifBpQHXqLZyCa3aqw5Kv397h2XECS2com8ug8dQM4 Error: Invalid negative reference count

leave-room-bug.compressed.mov

[taoeffect]

Great work @Silver-IT! I tested it and the previous error is gone now!

One comment left.

[taoeffect]

There are multiple problems here.

1. The code for which this was a comment was moved. Now this is a .then handler that does nothing and the comment here is not for anything.
2. The code below with .catch is also nonsensical.

So to fix this, please move this comment to where you moved sbp('state/vuex/state').loggedIn.identityContractID, because it must stay with it. In this case, above line 1265.

Then remove the .then that does nothing, and replace the two .catch with one:

  }).catch((e) => {
    if (
      leavingGroup &&
      (e?.name === 'ChelErrorSignatureKeyNotFound' || (
        e?.name === 'GIErrorUIRuntimeError' &&
        (
          ['ChelErrorSignatureKeyNotFound', 'GIErrorMissingSigningKeyError'].includes(e?.cause?.name) ||
          e?.cause?.name === 'GIChatroomNotMemberError'
        )
      ))
    ) {
      // This is fine; it just means we were removed by someone else
      return
    }
    console.warn('[gi.contracts/group] Error sending chatroom leave action', e)
  })

[taoeffect]

Some questions...

[taoeffect]

Great work @Silver-IT ! Approved!