Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set safe char limit for pledge, need, mincome #2218

Closed
dotmacro opened this issue Jul 18, 2024 · 3 comments · Fixed by #2224
Closed

Set safe char limit for pledge, need, mincome #2218

dotmacro opened this issue Jul 18, 2024 · 3 comments · Fixed by #2224

Comments

@dotmacro
Copy link
Member

dotmacro commented Jul 18, 2024

Problem

On testing, there is no upper limit for pledge, and entering too big of a pledge effectively breaks the app.

The entry appears to be saved (i.e. no error indicating otherwise) and the user is returned to the dashboard. However, nothing else seems to work again -- no buttons, menus, or links respond to clicks. When refreshed, the Dashboard is blank and the right menu is missing.

User pledges a lot
pledgeInfinite

User refreshes dashboard because nothing is responding to clicks, dashboard goes blank
pledgeInfinite-refreshLosesDashboard

pledge-outOfMemory

Solution

Fix.

@dotmacro
Copy link
Member Author

Note: This prevents the user from switching groups or logging out.

@taoeffect
Copy link
Member

As far as a suggested fix, please limit the upper range of the pledge to 1000000000. Think that should be sufficient. :)

@dotmacro
Copy link
Member Author

This also affects any other groups that user is a member of. Closing the tab and reopening switches to the first group in my group list (which isn't the one with the one hundred twenty-three octillion dollar pledge). The dashboard in that group seems to be properly populated with everything that should be there, but the app still does not respond to clicks etc.

SebinSong added a commit that referenced this issue Jul 18, 2024
taoeffect pushed a commit that referenced this issue Jul 19, 2024
* add upper-limit for group pledge amount

* update constant

* work on CRs

* add comments

* work on change requests

* change var name

* back to max
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants