Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(updater): detect p10k instant prompt #12971

Merged
merged 1 commit into from
Feb 13, 2025
Merged

fix(updater): detect p10k instant prompt #12971

merged 1 commit into from
Feb 13, 2025

Conversation

mcornella
Copy link
Member

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

  • Detects p10k instant prompt
  • Uses silent verbosity mode if enabled

Fixes #12781

@ohmyzsh ohmyzsh bot added Area: core Issue or PR related to core parts of the project Area: updater Update subsystem labels Feb 12, 2025
@mcornella mcornella force-pushed the fix/upgrade-with-p10k-instant-prompt branch from 4f44416 to 329869d Compare February 12, 2025 19:38
This was referenced Feb 12, 2025
Closed
Closed
carlosala
carlosala approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@carlosala carlosala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool!

@mcornella mcornella merged commit 7d32e7f into ohmyzsh:master Feb 13, 2025
2 checks passed
tom-mpls added a commit to tom-mpls/ohmyzsh that referenced this pull request Feb 16, 2025
@tom-mpls @ohmyzsh
@dependabot @kahlstrm @pvbhanuteja @carlosala @mephesto1337 @mbologna @nicojust @abhivashistha5 @felipec @mcornella @jamesrtnz @keithrbennett @thethomasboyer @fossdd @shun095 @Ken-vdE @euamotubaina @marcusvoltolim @guspan-tanadi @soemiran @mensinda @dskecse @ssgelm @Kilobyte22 @Kekun
Catch up (#1)
60b5633 
* feat(z): update to dd94ef04 (ohmyzsh#12862)

Co-authored-by: ohmyzsh[bot] <54982679+ohmyzsh[bot]@users.noreply.github.com>

* chore(deps): bump urllib3 from 2.2.3 to 2.3.0 in /.github/workflows/dependencies (ohmyzsh#12863)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump charset-normalizer in /.github/workflows/dependencies (ohmyzsh#12874)

Bumps [charset-normalizer](https://github.com/jawah/charset_normalizer) from 3.4.0 to 3.4.1.
- [Release notes](https://github.com/jawah/charset_normalizer/releases)
- [Changelog](https://github.com/jawah/charset_normalizer/blob/master/CHANGELOG.md)
- [Commits](jawah/charset_normalizer@3.4.0...3.4.1)

---
updated-dependencies:
- dependency-name: charset-normalizer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(af-magic): add logic for virtualenv separator (ohmyzsh#12875)

* feat(web-search): add perplexity.ai (ohmyzsh#12815)

* fix(cli): ensure `ksharrays` is unset

Closes ohmyzsh#12900

* fix(rust): call `rustc` through `rustup run` (ohmyzsh#12901)

* fix(grc): add linuxbrew path (ohmyzsh#12903)

* feat(eza): add color-scale options (ohmyzsh#12841)

* fix(sonicradish): reset color typo (ohmyzsh#12912)

* ci(deps): update `gitfast` to its new structure (ohmyzsh#12922)

Co-authored-by: Carlo Sala <carlosalag@protonmail.com>

* feat(gitfast): update to version v2.2 (ohmyzsh#12923)

Co-authored-by: ohmyzsh[bot] <54982679+ohmyzsh[bot]@users.noreply.github.com>

* chore(deps): bump semver in /.github/workflows/dependencies (ohmyzsh#12924)

Bumps [semver](https://github.com/python-semver/python-semver) from 3.0.2 to 3.0.3.
- [Release notes](https://github.com/python-semver/python-semver/releases)
- [Changelog](https://github.com/python-semver/python-semver/blob/master/CHANGELOG.rst)
- [Commits](python-semver/python-semver@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat(python): support multiple venvs via `$PYTHON_VENV_NAMES` (ohmyzsh#12932)

* fix(tailscale): fix completion binding for alias to `Tailscale` (ohmyzsh#12928)

Fixes ohmyzsh#12928

* feat(perl): add `perlbrew` auto activation (ohmyzsh#12814)

Co-authored-by: Carlo Sala <carlosalag@protonmail.com>

* docs(chucknorris): add useful note (ohmyzsh#12822)

* fix(direnv): warn user if command not found (ohmyzsh#12840)

Co-authored-by: Carlo Sala <carlosalag@protonmail.com>

* fix(changelog): show if there are no changes (ohmyzsh#12934)

* feat(foot): add foot plugin (ohmyzsh#12849)

* fix(timer): minutes calculation logic (ohmyzsh#12857)

* fix(cli)!: remove harmful `--unattended` flag for `omz update` (ohmyzsh#12935)

Co-authored-by: Carlo Sala <carlosalag@protonmail.com>

* feat(jira): allow branch name customization (ohmyzsh#12850)

Co-authored-by: Carlo Sala <carlosalag@protonmail.com>

* chore: ignore `.zwc` files (ohmyzsh#12936)

* docs(git-auto-fetch): fix typo (ohmyzsh#12937)

* chore(deps): bump semver from 3.0.3 to 3.0.4 in /.github/workflows/dependencies (ohmyzsh#12938)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat(dnf): add `dnf5` completion

Closes ohmyzsh#12939

* docs(ember-cli): fix typo (ohmyzsh#12945)

* feat(terraform): support `TF_DATA_DIR` in `tf_prompt_info` (ohmyzsh#12949)

* feat(wd): update to v0.9.3 (ohmyzsh#12954)

Co-authored-by: ohmyzsh[bot] <54982679+ohmyzsh[bot]@users.noreply.github.com>

* chore(deps): bump certifi in /.github/workflows/dependencies (ohmyzsh#12955)

Bumps [certifi](https://github.com/certifi/python-certifi) from 2024.12.14 to 2025.1.31.
- [Commits](certifi/python-certifi@2024.12.14...2025.01.31)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(mvn): handle directories in `<relativePath>` (ohmyzsh#12957)

* feat(asdf): support asdf v0.16 ahead

Co-authored-by: Valgard Trontheim <github@trontheim.de>

Closes ohmyzsh#12964
Closes ohmyzsh#12967

* fix(chruby): update brew sourcing for Apple Silicon (ohmyzsh#12941)

Co-authored-by: Carlo Sala <carlosalag@protonmail.com>

* feat(agnoster): add color config and add some git stuff (ohmyzsh#12505)

Co-authored-by: Kilobyte22 <stiepen22@gmx.de>
Co-authored-by: Carlo Sala <carlosalag@protonmail.com>

* fix(updater): detect p10k instant prompt (ohmyzsh#12971)

Fixes ohmyzsh#12781

* fix(agnoster): print white text over black (ohmyzsh#12525)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: ohmyzsh[bot] <54982679+ohmyzsh[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kalle Ahlström <71292737+kahlstrm@users.noreply.github.com>
Co-authored-by: Bhanu <pvbhanuteja@gmail.com>
Co-authored-by: Carlo Sala <carlosalag@protonmail.com>
Co-authored-by: Thomas <thomas@wache.fr>
Co-authored-by: Michele Bologna <github@michelebologna.net>
Co-authored-by: Nico Just <nicojust@users.noreply.github.com>
Co-authored-by: Abhijeet Vashistha <abhivashistha5@gmail.com>
Co-authored-by: Felipe Contreras <felipe.contreras@gmail.com>
Co-authored-by: Marc Cornellà <marc@mcornella.com>
Co-authored-by: jamesrtnz <jamesrt@gmail.com>
Co-authored-by: Keith Bennett <keithrbennett@gmail.com>
Co-authored-by: Thomas Boyer <warbeaver@pm.me>
Co-authored-by: fossdd <fossdd@pwned.life>
Co-authored-by: shun095 <8069181+shun095@users.noreply.github.com>
Co-authored-by: Ken van der Eerden <15888558+Ken-vdE@users.noreply.github.com>
Co-authored-by: Eduardo Roberto <euamotubaina@gmail.com>
Co-authored-by: Marcus Voltolim <9442331+marcusvoltolim@users.noreply.github.com>
Co-authored-by: Guspan Tanadi <36249910+guspan-tanadi@users.noreply.github.com>
Co-authored-by: soemiran <erwan.miran@saas-office.com>
Co-authored-by: Daniel Mensinger <daniel@mensinger-ka.de>
Co-authored-by: Dennis Dashkevich <dskecse@gmail.com>
Co-authored-by: Stephen Gelman <ssgelm@gmail.com>
Co-authored-by: Kilobyte22 <stiepen22@gmx.de>
Co-authored-by: Adrien Plazas <kekun.plazas@laposte.net>
@mcornella mcornella deleted the fix/upgrade-with-p10k-instant-prompt branch February 17, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli left review comments

@carlosala carlosala carlosala approved these changes

Assignees
No one assigned
Labels
Area: core Issue or PR related to core parts of the project Area: updater Update subsystem
Projects
Main project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

check_for_upgrade fails on MacOS terminal launch
3 participants
@mcornella @GuySartorelli @carlosala