Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test files to reduce gem size #952

Merged

Conversation

ybiquitous
Copy link

Closes #951
Follows up to #771

This aims to reduce the gem package size by removing test files from a built gem.

Closes #951
Follows up to #771

This aims to reduce the gem package size by removing test files from a built gem.
@ybiquitous ybiquitous marked this pull request as ready for review January 14, 2025 07:00
Copy link
Collaborator

@Watson1978 Watson1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ybiquitous
Copy link
Author

Thanks for the quick review 😄

To resolve the CI failure, it seems necessary to add gem 'logger' to gemfiles/rails_7.gemfile:

/home/runner/work/oj/oj/vendor/bundle/ruby/3.5.0+0/gems/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/concern/logging.rb:1: warning: logger was loaded from the standard library, but is not part of the default gems starting from Ruby 3.5.0.
You can add logger to your Gemfile or gemspec to silence this warning.
/home/runner/.rubies/ruby-head/lib/ruby/3.5.0+0/bundled_gems.rb:76:in 'Kernel.require': cannot load such file -- logger (LoadError)

https://github.com/ohler55/oj/actions/runs/12762636078/job/35575532139?pr=952#step:4:68

@ohler55 ohler55 merged commit 5272aa7 into ohler55:develop Jan 14, 2025
52 of 53 checks passed
@ybiquitous ybiquitous deleted the issue-951-remove-test-files-from-gem branch January 15, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove test files to reduce gem size
3 participants