Incorrect Year according to Week Display on Leaderboard #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for leaderboard-develop pending review.Visit the deploys page to approve it
|
|
This will solve the issue. |
|
|
rithviknishad
requested changes
Dec 31, 2024
|
According the ISO rule it should be "Week 1 of 2025" but your right, it should make sense to common man. I have made the changes according. Updated Code Screenshot
|
|
the right answer for today is, week 53. isn't the current logic incorrect? shows 9 entries for week 52 when i tested your logic. 
|
|
@rithviknishad I fixed the issue, kindly review it. Thank you! |
rithviknishad
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are following the ISO Week Number Calculation, it was supposed to display as "Week 1 of 2025" instead of "Week 1 of 2024"
The function was supposed correctly identify December 31, 2024 as part of week 1 of 2025 because it falls after the last Thursday of 2024 (which is December 26, 2024). While the function accurately determines the week number, it fails to handle the year correctly.
This change ensures that both the week number and year correctly reflect the ISO week date standards, especially at the boundaries between years.