Fix : DOM nesting Warning in BreadcrumbSeparator #9940

Rustix69 · 2025-01-13T22:58:21Z

Proposed Changes :

Fixes Fix DOM Nesting Warning in BreadcrumbSeparator Component #9936
Changed the (li) component to (span) component as it violates the descendant rules.

Screenshots :

Plz review : @ohcnetwork/care-fe-code-reviewers

Summary by CodeRabbit

UI Improvements
- Updated Breadcrumb Separator component to use <span> instead of <li>
- Fixed display name typo for BreadcrumbEllipsis component

coderabbitai · 2025-01-13T22:58:30Z

Walkthrough

The pull request modifies the BreadcrumbSeparator component in the src/components/ui/breadcrumb.tsx file. The primary change involves switching the component's rendered element from a <li> to a <span>, addressing a DOM nesting warning. This modification ensures proper HTML structure for breadcrumb rendering while maintaining the existing accessibility attributes and default icon behavior.

Changes

File	Change Summary
`src/components/ui/breadcrumb.tsx`	- Updated `BreadcrumbSeparator` component props from `<li>` to `<span>` - Changed rendered element from `<li>` to `<span>` - Corrected typo in `BreadcrumbEllipsis.displayName`

Assessment against linked issues

Objective	Addressed	Explanation
Fix DOM Nesting Warning [#9936]	✅

Possibly related issues

Fix Invalid <li> Nesting in BreadcrumbSeparator Component (#XXXX) #9923: Addresses similar DOM nesting warning for BreadcrumbSeparator component

Possibly related PRs

FIXED: Implement Dropdown for Hidden Breadcrumb Paths Across the Platform #9413: Modifies BreadcrumbSeparator component usage within Breadcrumbs

Suggested labels

tested, reviewed

Suggested reviewers

rithviknishad
Jacobjeevan

Poem

🐰 A breadcrumb's path, once tangled tight,
Now spans with grace, a cleaner sight!
From <li> to <span>, we leap with glee,
No warnings dance, our DOM runs free! 🍞✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-01-13T22:58:45Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`75e1dd9`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67859a90b400ad00086b16b5
😎 Deploy Preview	https://deploy-preview-9940--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/ui/breadcrumb.tsx (1)
Line range hint 104-104: Fix typo in BreadcrumbEllipsis display name.

There's a typo in the display name: "BreadcrumbElipssis" has an extra 's'. While not related to the DOM nesting fix, we should correct it for consistency.
-BreadcrumbEllipsis.displayName = "BreadcrumbElipssis";
+BreadcrumbEllipsis.displayName = "BreadcrumbEllipsis";

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fc4c3d5 and 75e1dd9.

📒 Files selected for processing (1)

src/components/ui/breadcrumb.tsx (1 hunks)

🔇 Additional comments (1)

src/components/ui/breadcrumb.tsx (1)

82-90: LGTM! The changes correctly address the DOM nesting warning.

The switch from <li> to <span> is the right approach here since the separator is decorative and shouldn't be part of the list structure. The accessibility attributes are maintained correctly.

Let's verify that this component is used correctly throughout the codebase:

✅ Verification successful

Verified: The component changes are safe and all usages are compatible

The search results confirm that BreadcrumbSeparator is used consistently across the codebase, and no usage relies on the li element behavior. All instances are simple separators within breadcrumb navigation, properly wrapped in BreadcrumbItem components.
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Check for any custom implementations or overrides of BreadcrumbSeparator
# that might still expect an li element

# Search for BreadcrumbSeparator usage
rg -A 3 "BreadcrumbSeparator" --type tsx --type jsx
Length of output: 79

Script:
#!/bin/bash
# Search for BreadcrumbSeparator in ts, tsx, js, jsx files
rg "BreadcrumbSeparator" -g "*.{ts,tsx,js,jsx}" -B 2 -A 3

# Also search for potential custom separator implementations
rg "Separator.*=.*props" -g "*.{ts,tsx,js,jsx}" -B 2 -A 3
Length of output: 4720

rithviknishad · 2025-01-14T02:12:09Z

this is something that needs to solved in https://github.com/ohcnetwork/care_fe/blob/develop/src/components/Common/Breadcrumbs.tsx and not by modifying shadcn's component
get issues assigned before working on them

Rustix69 · 2025-01-14T05:45:07Z

this is something that needs to solved in https://github.com/ohcnetwork/care_fe/blob/develop/src/components/Common/Breadcrumbs.tsx and not by modifying shadcn's component

get issues assigned before working on them

Can I work on this issue then ?

rithviknishad · 2025-01-14T06:14:39Z

request in the issue to get it assigned. github doesn't allow assigning to anyone.

Fix : DOM nesting Warning in BreadcrumbSeparator

75e1dd9

Rustix69 requested a review from a team as a code owner January 13, 2025 22:58

coderabbitai bot reviewed Jan 13, 2025

View reviewed changes

rithviknishad closed this Jan 14, 2025

github-actions bot added needs-triage question Further information is requested labels Jan 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix : DOM nesting Warning in BreadcrumbSeparator #9940

Fix : DOM nesting Warning in BreadcrumbSeparator #9940

Rustix69 commented Jan 13, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 13, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Jan 13, 2025 •

edited

Loading

coderabbitai bot left a comment

rithviknishad commented Jan 14, 2025

Rustix69 commented Jan 14, 2025

rithviknishad commented Jan 14, 2025

Fix : DOM nesting Warning in BreadcrumbSeparator #9940

Fix : DOM nesting Warning in BreadcrumbSeparator #9940

Conversation

Rustix69 commented Jan 13, 2025 • edited by coderabbitai bot Loading

Proposed Changes :

Screenshots :

Summary by CodeRabbit

coderabbitai bot commented Jan 13, 2025 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Jan 13, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

coderabbitai bot left a comment

Choose a reason for hiding this comment

rithviknishad commented Jan 14, 2025

Rustix69 commented Jan 14, 2025

rithviknishad commented Jan 14, 2025

Rustix69 commented Jan 13, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 13, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Jan 13, 2025 •

edited

Loading