Fix: Highlight Only Active Tab in Navigation Bar

[JavidSumra]

Proposed Changes

• Fixes Multiple Tabs Marked as Active in Navigation Bar When Switching Between Tabs #9637
• Using useActiveLink hook to detect active path and removing exactActiveClass and activeClass from ActiveLink Component.

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

Summary by CodeRabbit

• New Features

  • Enhanced navigation link highlighting mechanism
  • Added support for active link detection on new routes including encounters, availability, and organization pages

• Refactor

  • Updated active link determination logic to improve navigation experience

[coderabbitai]

Walkthrough

The pull request modifies the active link detection mechanism in the navigation sidebar. A new useActiveLink hook is introduced to improve how active links are determined. The changes involve updating the activeLinkPriority object with new path entries and adjusting the link activation logic in the NavMain component to more accurately highlight the currently selected tab.

Changes

File	Change Summary
src/components/ui/sidebar/nav-main.tsx	- Added import for useActiveLink hook - Introduced activePath constant - Modified active link className logic
src/hooks/useActiveLink.ts	- Added new entries to activeLinkPriority for /encounters, /availability, and /organization

Assessment against linked issues

Objective	Addressed	Explanation
Fix multiple tabs being marked active simultaneously [#9637]	✅

Possibly related PRs

• fixes dropdown click events issue #9047: SidebarUserCard dropdown menu modifications
• Fix bug with recursion #9100: Consultation details tab management improvements
• Fix: UI changes in shifting and resources pages #9437: UI changes in ResourceBoard and ResourceList
• Fixes sidebar shown for session expired #9642: Sidebar visibility based on session status

Suggested labels

needs review, tested

Suggested reviewers

• rithviknishad
• khavinshankar

Poem

🐰 A rabbit's tale of navigation's grace,
Where links now dance with precision and pace
No more confusion, no tabs astray
One path shines bright, leading the way!
Hop, hop, hooray! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	0978e48
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/6777c9e847b1ad000851d09e
😎 Deploy Preview	https://deploy-preview-9695--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/ui/sidebar/nav-main.tsx (1)

41-46: Handle the null assertion operator.

Forcing non-null with activePath! can mask potential issues if the hook returns undefined. Consider handling this scenario gracefully:

-link.url.endsWith(activePath!) ||
-link.name.toLowerCase() === activePath!.split("/")[1]
+link.url.endsWith(activePath ?? "") ||
+(activePath && link.name.toLowerCase() === activePath.split("/")[1])

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 54781a5 and 04ef4bf.

📒 Files selected for processing (2)

• src/components/ui/sidebar/nav-main.tsx (3 hunks)
• src/hooks/useActiveLink.ts (1 hunks)

🔇 Additional comments (3)

src/hooks/useActiveLink.ts (1)

16-16: Good expansion of active link priority.

The addition of "/encounters", "/availability", and "/organization" to the activeLinkPriority object appears consistent with the PR objective of accurately highlighting active links. Consider adding relevant test coverage to ensure these new paths are properly recognized as active.

Also applies to: 21-21, 24-24

src/components/ui/sidebar/nav-main.tsx (2)

14-15: New hook import.

Great job importing the useActiveLink hook. Make sure to remove any remaining references to exactActiveClass or activeClass from older code if they still persist in the repository.

---

25-25: Usage clarity.

The useActiveLink hook usage is simple and effective. Ensure there's adequate testing for edge cases where useActiveLink might return undefined or an unexpected path.

[bodhish]

Bug

Fuly broken in orgs