Updated UX for ValueSetSelect component #9685

abhimanyurajeesh · 2025-01-03T07:35:59Z

Proposed Changes

Fixes Improving UX for ValueSetSelect component #9681
Change 1: updated an encounter that uses ValueSetSelect,
Change 2: added key to en.json

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Screenshot

Summary by CodeRabbit

New Features
- Added localized messages for search functionality
  - "Searching..." indicator
  - Minimum character search prompt for search length under 3 characters
  - "No results found" message
Internationalization
- Enhanced ValueSetSelect component with context-sensitive search feedback
- Integrated translation support for search-related messages

coderabbitai · 2025-01-03T07:36:07Z

Walkthrough

The pull request updates the ValueSetSelect component to enhance user experience through internationalization support. The component now utilizes the useTranslation hook to provide localized feedback based on the search length and fetching state. Additionally, the English JSON locale file has been modified to reflect these changes, specifically updating the "searching" message to indicate an ongoing process.

Changes

File	Change Summary
`public/locale/en.json`	Updated `"searching"` value from `"Searching"` to `"Searching..."`
`src/components/Questionnaire/ValueSetSelect.tsx`	- Removed `noResultsMessage` prop - Integrated `useTranslation` hook - Updated message display logic based on search length and fetching state

Assessment against linked issues

Objective	Addressed	Explanation
Improve UX for ValueSetSelect	✅
Provide guidance for minimum search characters	✅

Possibly related PRs

Fixed: No notification shown when invalid OTP is entered #9667: This PR modifies the same JSON file (public/locale/en.json) as the main PR, adding a new key-value pair for handling invalid OTP messages, which is related to localization changes.

Suggested labels

needs testing, needs review

Suggested reviewers

Jacobjeevan

Poem

🐰 In the meadow, a search takes flight,
With messages clear, guiding the light.
Type three characters, and watch the fun,
"Searching..." we say, till the quest is done!
Hop along, dear friend, the path is bright! 🌟

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6363a58 and e79d2b2.

📒 Files selected for processing (2)

public/locale/en.json (1 hunks)
src/components/Questionnaire/ValueSetSelect.tsx (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

public/locale/en.json
src/components/Questionnaire/ValueSetSelect.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-01-03T07:36:17Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`e79d2b2`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67779c9d4a58160008dc3309
😎 Deploy Preview	https://deploy-preview-9685--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/Questionnaire/ValueSetSelect.tsx (1)
45-45: Consider localizing the placeholder text as well.

While the rest of the user-facing text is now internationalized, the placeholder = "Search..." string remains hardcoded in English. You can further enhance i18n coverage by moving it into the translation file.
-  placeholder = "Search...",
+  placeholder = t("valueSetSelect_placeholder"),

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ee27ecd and 6363a58.

📒 Files selected for processing (2)

public/locale/en.json (1 hunks)
src/components/Questionnaire/ValueSetSelect.tsx (3 hunks)

🔇 Additional comments (3)

src/components/Questionnaire/ValueSetSelect.tsx (2)

3-3: Good use of i18n for messaging.

Importing and using useTranslation is a clean approach to localize user-facing messages in the component.

86-92: Logical flow for conditional messages looks correct.

Contextual messaging based on search length, loading state, and empty results is clearly structured. This greatly improves user guidance during search operations.

public/locale/en.json (1)

1810-1812: Keys align well with component usage.

The newly added keys match perfectly with the conditional logic in ValueSetSelect.tsx.

abhimanyurajeesh · 2025-01-03T07:41:18Z

@rithviknishad please look into it and let me if any changes required, thank you !

src/components/Questionnaire/ValueSetSelect.tsx

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>

…e_fe into setvalueFix

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>

github-actions · 2025-01-03T09:20:57Z

@abhimanyurajeesh Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

abhimanyurajeesh added 2 commits January 3, 2025 11:34

updated the ValueSet

3c4b352

updated ValueSet & enjson

6363a58

abhimanyurajeesh requested a review from a team as a code owner January 3, 2025 07:36

coderabbitai bot reviewed Jan 3, 2025

View reviewed changes

Merge branch 'develop' into setvalueFix

3fea5d6

rithviknishad requested changes Jan 3, 2025

View reviewed changes

src/components/Questionnaire/ValueSetSelect.tsx Outdated Show resolved Hide resolved

src/components/Questionnaire/ValueSetSelect.tsx Outdated Show resolved Hide resolved

src/components/Questionnaire/ValueSetSelect.tsx Outdated Show resolved Hide resolved

abhimanyurajeesh and others added 5 commits January 3, 2025 13:30

updated key

6d24fd5

Update src/components/Questionnaire/ValueSetSelect.tsx

1939e4d

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>

Merge branch 'setvalueFix' of https://github.com/abhimanyurajeesh/car…

3dc234d

…e_fe into setvalueFix

Update src/components/Questionnaire/ValueSetSelect.tsx

84adfc3

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>

removed key some values

e79d2b2

abhimanyurajeesh requested a review from rithviknishad January 3, 2025 08:19

rithviknishad approved these changes Jan 3, 2025

View reviewed changes

rithviknishad added the good to merge label Jan 3, 2025

rithviknishad approved these changes Jan 3, 2025

View reviewed changes

rithviknishad merged commit 0899ddf into ohcnetwork:develop Jan 3, 2025
21 checks passed

This was referenced Jan 11, 2025

Encounter Qustions dropdown values moved to constants and i18 applied for all strings #9859

Merged

MultiValueSetField for Medication Request Instructions #9996

Merged

Refactor questionnaire response and migrated to TanStack's query #9995

Merged

coderabbitai bot mentioned this pull request Jan 19, 2025

Fixed text overflow in search results to prevent UI distortion #10055

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated UX for ValueSetSelect component #9685

Updated UX for ValueSetSelect component #9685

abhimanyurajeesh commented Jan 3, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 3, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Jan 3, 2025 •

edited

Loading

coderabbitai bot left a comment

abhimanyurajeesh commented Jan 3, 2025

github-actions bot commented Jan 3, 2025

Updated UX for ValueSetSelect component #9685

Updated UX for ValueSetSelect component #9685

Conversation

abhimanyurajeesh commented Jan 3, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Screenshot

Summary by CodeRabbit

coderabbitai bot commented Jan 3, 2025 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Jan 3, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

coderabbitai bot left a comment

Choose a reason for hiding this comment

abhimanyurajeesh commented Jan 3, 2025

github-actions bot commented Jan 3, 2025

abhimanyurajeesh commented Jan 3, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 3, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Jan 3, 2025 •

edited

Loading