OTP flow: switching to schedulable users and user base

[Jacobjeevan]

Proposed Changes

• Switched to using new routes
• To do: BE OTP slots_for_the_day route needs to be fixed (@rithviknishad handling this), but ensure rest of the flow works once that is done.

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

Summary by CodeRabbit

Release Notes

• Routing Updates

  • Updated route parameters from staffUsername and staffExternalId to staffId across multiple routes and components
  • Standardized staff identification across appointment-related pages

• API Changes

  • Modified response type for getScheduleAbleFacilityUser endpoint
  • Updated type mapping for user data retrieval

• User Interface

  • Refined navigation logic for staff-related routes
  • Updated user identification and routing mechanisms

These changes improve consistency in staff identification and routing throughout the application.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces a systematic renaming of staff-related parameters across multiple components and routes, primarily changing staffUsername and staffExternalId to staffId. The modifications span several files in the appointments and routing sections, ensuring consistent parameter naming throughout the application. The changes maintain the existing functionality while standardizing the identification of staff members across different routes and components.

Changes

File	Change Summary
src/Routers/SessionRouter.tsx	Updated route signatures to replace :staffUsername and :staffExternalId with :staffId
src/Utils/request/api.tsx	Modified getScheduleAbleFacilityUser endpoint response type from UserAssignedModel to UserBase
src/pages/Appoinments/PatientRegistration.tsx	Renamed staffUsername prop to staffId in component and type definition
src/pages/Appoinments/PatientSelect.tsx	Replaced staffUsername with staffId in props and related logic
src/pages/Appoinments/Schedule.tsx	Updated staffExternalId to staffId in props and component logic
src/pages/Appoinments/auth/PatientLogin.tsx	Renamed staffUsername prop to staffId
src/pages/Facility/components/UserCard.tsx	Updated link generation to use user.id instead of user.external_id

Sequence Diagram

sequenceDiagram
    participant Router
    participant Component
    participant API
    
    Router->>Component: Pass staffId
    Component->>API: Request with staffId
    API-->>Component: Return user data
    Component->>Router: Navigate using staffId

Loading

Possibly related PRs

• Add function to authorize user to register patient #9000: Changes to patient registration process
• New Cypress Test for HCX Workflow in the platform #9007: Testing of patient registration workflow
• Fix: Duplicate network requests in Patient Details page #9297: Addressing duplicate network requests
• New Patient Search and Register UI #9400: New patient registration UI
• Fix: Pressing “Enter” After Entering Data in Patient Registration Form Refreshes #9655: Form submission fixes in Patient Registration

Suggested Labels

needs review, needs testing, P1

Suggested Reviewers

• gigincg
• Jacobjeevan

Poem

🐰 Hop, hop, through the code we go,
Renaming staff with a rhythmic flow
From username to ID so neat
Our routing dance is now complete!
A rabbit's refactor, clean and bright 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2dfac5c and 316a73e.

📒 Files selected for processing (7)

• src/Routers/SessionRouter.tsx (1 hunks)
• src/Utils/request/api.tsx (1 hunks)
• src/pages/Appoinments/PatientRegistration.tsx (3 hunks)
• src/pages/Appoinments/PatientSelect.tsx (4 hunks)
• src/pages/Appoinments/Schedule.tsx (7 hunks)
• src/pages/Appoinments/auth/PatientLogin.tsx (5 hunks)
• src/pages/Facility/components/UserCard.tsx (1 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	316a73e
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67769ec8dd9f3b000887c11e
😎 Deploy Preview	https://deploy-preview-9626--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

@Jacobjeevan Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌