Remove special character validations for names (patients and users) #9177

rithviknishad · 2024-11-21T15:44:57Z

Proposed Changes

This reverts commit ff63195. Reason: Patient created despite having numeric values in name #9143 (comment)
Also removes numeric validation check for care user's names.

Summary by CodeRabbit

New Features
- Introduced a minimum character length requirement for name fields in both user and patient registration forms.
Bug Fixes
- Ensured pincode validation is retained and correctly implemented in the Patient Register component.
- Improved error messaging for name fields to provide clearer feedback on validation requirements.
Refactor
- Updated form validation logic across components to enhance clarity and maintainability while preserving functionality for other fields.
- Simplified validation process for names to check for a minimum length of three characters.

…values (#9152)" This reverts commit ff63195.

coderabbitai · 2024-11-21T15:45:06Z

Walkthrough

The changes in this pull request involve updating the validateName function in the src/common/validation.tsx file to a simpler length check of at least three characters. The PatientRegister.tsx and UserAdd.tsx components have been modified to reflect this new validation logic, ensuring that the name field is now validated for length rather than format. Other validation functions and the overall structure of the components remain unchanged.

Changes

File	Change Summary
`src/common/validation.tsx`	Updated `validateName` function to check if name length is at least 3 characters.
`src/components/Patient/PatientRegister.tsx`	Updated `validateForm` to include a required field check for name and validate its length.
`src/components/Users/UserAdd.tsx`	Simplified validation logic for `first_name` and `last_name` to require a minimum length of 3 characters.
`public/locale/en.json`	Added new key `min_char_length_error` for error messaging related to minimum character length.

Possibly related PRs

Added SpO2 field in community log update for nurses #8907: This PR modifies the validation logic for names in the UserAdd component to require a minimum length of 3 characters, which aligns with the changes made to the validateName function in the main PR.
fix: Resolve creation of patient name despite having numeric values #9152: This PR enhances the PatientRegister component by integrating a new validateName function to ensure that patient names do not contain numeric values, directly relating to the changes in the validateName function in the main PR.

Suggested labels

tested

Suggested reviewers

shivankacker
Jacobjeevan

Poem

In fields of code where rabbits play,
The validateName has hopped away.
With forms so neat and logic clear,
We celebrate this change, oh dear!
No more name checks, just let it be,
A simpler path for you and me! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint (1.23.1)

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/common/validation.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

Error: Failed to load parser '@typescript-eslint/parser' declared in '.eslintrc.json': Cannot find module '@typescript-eslint/parser'
Require stack:

/.eslintrc.json
at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15)
at Function.resolve (node:internal/modules/helpers:145:19)
at Object.resolve (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2346:46)
at ConfigArrayFactory._loadParser (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3325:39)
at ConfigArrayFactory._normalizeObjectConfigDataBody (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3099:43)
at _normalizeObjectConfigDataBody.next ()
at ConfigArrayFactory._normalizeObjectConfigData (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3040:20)
at _normalizeObjectConfigData.next ()
at ConfigArrayFactory.loadInDirectory (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2886:28)
at CascadingConfigArrayFactory._loadConfigInAncestors (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3871:46)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6e6a876 and b8d1d27.

📒 Files selected for processing (4)

public/locale/en.json (1 hunks)
src/common/validation.tsx (1 hunks)
src/components/Patient/PatientRegister.tsx (1 hunks)
src/components/Users/UserAdd.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

src/common/validation.tsx
src/components/Patient/PatientRegister.tsx
src/components/Users/UserAdd.tsx

🔇 Additional comments (1)

public/locale/en.json (1)

872-872: LGTM! The new validation message follows established conventions.

The added translation key min_char_length_error with the message "Must be at least {{ min_length }} characters" is:

Properly formatted with correct variable interpolation
Follows the existing naming convention for validation messages
Placed in the correct alphabetical order

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2024-11-21T15:45:12Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`b8d1d27`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/673f637525cb170008868674
😎 Deploy Preview	https://deploy-preview-9177--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cloudflare-workers-and-pages · 2024-11-21T15:46:14Z

Deploying care-fe with Cloudflare Pages

Latest commit:	`b8d1d27`
Status:	✅ Deploy successful!
Preview URL:	https://10fc6e18.care-fe.pages.dev
Branch Preview URL:	https://revert-disallow-numeric-char.care-fe.pages.dev

View logs

coderabbitai

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

src/components/Patient/PatientRegister.tsx (1)
Line range hint 435-441: Consider documenting the name transformation behavior.

While name validation has been removed, the code still transforms the name using startCase(toLower()). This ensures consistent capitalization but might need documentation for maintainers.

Add a comment explaining the name transformation:
 name: startCase(toLower(formData.name)),
+// Ensures consistent name capitalization: first letter of each word capitalized

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 10369c5 and 6e6a876.

📒 Files selected for processing (3)

src/common/validation.tsx (0 hunks)
src/components/Patient/PatientRegister.tsx (1 hunks)
src/components/Users/UserAdd.tsx (0 hunks)

💤 Files with no reviewable changes (2)

src/common/validation.tsx
src/components/Users/UserAdd.tsx

🔇 Additional comments (2)

src/components/Patient/PatientRegister.tsx (2)

Line range hint 392-419: Review duplicate patient detection logic.

With the removal of name validation restrictions, the duplicate patient detection logic might need review. Currently, it only checks phone numbers, which could lead to more duplicate records now that name validation is relaxed.

Let's check the duplicate detection implementation:

72-72: Confirm the removal of name validation.

The removal of the validateName import aligns with the revert PR's objective. This change allows for more flexible name inputs by only validating that the field is non-empty.

Let's verify if there are any remaining references to name validation:

cypress · 2024-11-21T15:54:46Z

CARE Run #3942

Run Properties: Passed #3942 • b8d1d27de7: Remove special character validations for names (patients and users)

Project	`CARE`
Branch Review	`revert-disallow-numeric-chars-in-patient-names`
Run status	`Passed #3942`
Run duration	`04m 57s`
Commit	`b8d1d27de7: Remove special character validations for names (patients and users)`
Committer	`Rithvik Nishad`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`129`
View all changes introduced in this branch ↗︎

src/common/validation.tsx

github-actions · 2024-11-21T16:23:17Z

Reminder: To add the "needs testing" label, comment "ready for testing" on this PR.

nihal467 · 2024-11-25T19:16:14Z

LGTM

bodhish

LGTM

github-actions · 2024-11-26T05:36:52Z

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

…hcnetwork#9177)

Revert "fix: Resolve creation of patient name despite having numeric …

4f2f526

…values (#9152)" This reverts commit ff63195.

rithviknishad requested a review from a team as a code owner November 21, 2024 15:44

removes numeric validation check for users too

6e6a876

rithviknishad mentioned this pull request Nov 21, 2024

fix: Resolve creation of patient name despite having numeric values #9152

Merged

6 tasks

rithviknishad added needs testing needs review labels Nov 21, 2024

rithviknishad changed the title ~~Revert "fix: Resolve creation of patient name despite having numeric values (#9152)"~~ Remove non-special character validations for names (patients and users) Nov 21, 2024

rithviknishad changed the title ~~Remove non-special character validations for names (patients and users)~~ Remove special character validations for names (patients and users) Nov 21, 2024

coderabbitai bot reviewed Nov 21, 2024

View reviewed changes

bodhish requested changes Nov 21, 2024

View reviewed changes

src/common/validation.tsx Show resolved Hide resolved

add min length validation

b8d1d27

rithviknishad requested a review from bodhish November 22, 2024 02:58

This was referenced Nov 22, 2024

Facility bed capacity verification test #9145

Merged

Unable to save form for patient details #9187

Closed

nihal467 added tested and removed needs testing labels Nov 25, 2024

bodhish approved these changes Nov 26, 2024

View reviewed changes

bodhish merged commit 10b562e into develop Nov 26, 2024
58 checks passed

bodhish deleted the revert-disallow-numeric-chars-in-patient-names branch November 26, 2024 05:36

rithviknishad self-assigned this Nov 26, 2024

Jacobjeevan mentioned this pull request Nov 26, 2024

Numeric values are not supporting on address field #9212

Closed

UdaySagar-Git pushed a commit to UdaySagar-Git/care_fe that referenced this pull request Dec 3, 2024

Remove special character validations for names (patients and users) (o…

d1af9ff

…hcnetwork#9177)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove special character validations for names (patients and users) #9177

Remove special character validations for names (patients and users) #9177

rithviknishad commented Nov 21, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 21, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Nov 21, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Nov 21, 2024 •

edited

Loading

coderabbitai bot left a comment

cypress bot commented Nov 21, 2024 •

edited

Loading

github-actions bot commented Nov 21, 2024

nihal467 commented Nov 25, 2024

bodhish left a comment

github-actions bot commented Nov 26, 2024

Remove special character validations for names (patients and users) #9177

Remove special character validations for names (patients and users) #9177

Conversation

rithviknishad commented Nov 21, 2024 • edited by coderabbitai bot Loading

Proposed Changes

Summary by CodeRabbit

coderabbitai bot commented Nov 21, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Nov 21, 2024 • edited Loading

✅ Deploy Preview for care-ohc ready!

cloudflare-workers-and-pages bot commented Nov 21, 2024 • edited Loading

Deploying care-fe with Cloudflare Pages

coderabbitai bot left a comment

Choose a reason for hiding this comment

cypress bot commented Nov 21, 2024 • edited Loading

CARE Run #3942

github-actions bot commented Nov 21, 2024

nihal467 commented Nov 25, 2024

bodhish left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 26, 2024

rithviknishad commented Nov 21, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 21, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Nov 21, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Nov 21, 2024 •

edited

Loading

cypress bot commented Nov 21, 2024 •

edited

Loading