-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setup-care-apps scripts to remove existing apps that are not configured in env if any #9052
Conversation
…onfigured in env if any
Caution Review failedThe pull request is closed. WalkthroughThe changes in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Script
participant AppsDir
participant BackupDir
User->>Script: Run setup-care-apps.js
Script->>AppsDir: Read contents of apps directory
AppsDir-->>Script: Return list of directories
Script->>Script: Filter directories based on REACT_ENABLED_APPS
Script->>BackupDir: Create apps_backup if not exists
Script->>BackupDir: Log and backup unused directories
Script->>AppsDir: Remove unused directories
Script->>AppsDir: Check existing applications
Script->>AppsDir: Clone or update specified applications
Possibly related PRs
Suggested reviewers
Warning Tool Failures:Tool Failure Count:Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
scripts/setup-care-apps.js (1)
Line range hint
1-65
: Consider architectural improvements for better reliability.The script handles critical operations and could benefit from:
- Implementing a transaction-like mechanism for atomic operations
- Adding progress tracking for long-running operations
- Implementing a rollback mechanism for failed operations
- Adding telemetry for monitoring script execution
This would make the script more reliable and easier to debug in production environments.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
scripts/setup-care-apps.js
(1 hunks)
🔇 Additional comments (1)
scripts/setup-care-apps.js (1)
56-65
: Verify dependencies before removing apps.
The cleanup operation might remove apps that are dependencies of enabled apps. Consider:
- Checking for dependencies between apps
- Optimizing the process to avoid unnecessary removals and re-clones
Let's verify if any removed apps are referenced as dependencies:
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@rithviknishad @rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit
New Features
apps
directory by automatically removing unused application directories.Bug Fixes